From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:48078)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1RmlYh-0001I0-9i
	for qemu-devel@nongnu.org; Mon, 16 Jan 2012 07:21:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1RmlYd-0000gQ-7v
	for qemu-devel@nongnu.org; Mon, 16 Jan 2012 07:21:07 -0500
Received: from mail-qw0-f45.google.com ([209.85.216.45]:58121)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1RmlYd-0000gD-5P
	for qemu-devel@nongnu.org; Mon, 16 Jan 2012 07:21:03 -0500
Received: by qabg40 with SMTP id g40so224607qab.4
	for <qemu-devel@nongnu.org>; Mon, 16 Jan 2012 04:21:02 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <4F14145C.90604@suse.de>
References: <1326674823-13069-1-git-send-email-afaerber@suse.de>
	<1326674823-13069-6-git-send-email-afaerber@suse.de>
	<CAFEAcA-nBKpgJPoWyqsVWu9doQCrwrCCGwTZiAWgdJWQUka=-A@mail.gmail.com>
	<4F14145C.90604@suse.de>
Date: Mon, 16 Jan 2012 12:21:02 +0000
Message-ID: <CAFEAcA_RKbpkuAXwgh0JrAxRYSAEvKjHP=8sNMLsffcLON8EYA@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 05/14] target-mips: Move definition of
 uint_fast{8, 16}_t to osdep.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>, Stefan Weil <weil@mail.berlios.de>, =?UTF-8?Q?Aur=C3=A9lien_Jarno?= <aurelien@aurel32.net>

On 16 January 2012 12:13, Andreas F=C3=A4rber <afaerber@suse.de> wrote:
> Am 16.01.2012 12:38, schrieb Peter Maydell:
>> On 16 January 2012 00:46, Andreas F=C3=A4rber <afaerber@suse.de> wrote:
>>> +#if defined(CONFIG_SOLARIS) && CONFIG_SOLARIS_VERSION < 10
>>> +/* uint_fast8_t and uint_fast16_t not in <sys/int_types.h> */
>>> +typedef unsigned char =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 uint_fast8_t;
>>> +typedef unsigned int =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0uint_fas=
t16_t;
>>> +#endif
>>
>> If you make the comment say
>> /* uint_fast*_t and int_fast*_t not in <sys/int_types.h> */
>>
>> then it won't become out of date when your later patches add
>> the other types to this section.
>
> I have no clue if that is the case, I just moved it and fixed the
> comment style. But sure, I can change the comment itself as well.

Well, your later patches add more typedefs here, right? So we need
to know: either old Solaris doesn't have any of these types and we
must typedef them all (and the comment should match that), or it
is only missing the two currently noted here, in which case we don't
need to and should not add further typedefs. What we don't want is
to have a comment and code which disagree...

-- PMM