From: Peter Maydell <peter.maydell@linaro.org>
To: Thomas Huth <thuth@redhat.com>
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: check-functional skipUnless failure
Date: Tue, 10 Sep 2024 12:18:31 +0100 [thread overview]
Message-ID: <CAFEAcA_SHQsD__V19dn_csDRt2Fx7uq8opnkpDCQqQ1MDv4KAQ@mail.gmail.com> (raw)
In-Reply-To: <b04d662f-0ec1-4c93-a67a-d0e77df271cd@redhat.com>
On Tue, 10 Sept 2024 at 08:37, Thomas Huth <thuth@redhat.com> wrote:
>
> On 10/09/2024 08.41, Philippe Mathieu-Daudé wrote:
> > While looking at this, I'm surprised to notice has_cmd() actually
> > *runs* the command by calling run_cmd(). I'd have expected it solely
> > checks for binary presence and RX perms, avoiding unexpected side
> > effects.
>
> It uses "which" to search for the binary ... that could be done better for
> sure (especially since "which" might not be available on all systems), but
> it already was done this way in the Avocado tests, so at least that's not a
> regression.
So it runs an external binary, but it doesn't run the command
being searched for; "which" won't have any side effects.
-- PMM
prev parent reply other threads:[~2024-09-10 11:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 3:58 check-functional skipUnless failure Richard Henderson
2024-09-10 6:41 ` Philippe Mathieu-Daudé
2024-09-10 7:36 ` Thomas Huth
2024-09-10 11:13 ` Philippe Mathieu-Daudé
2024-09-10 11:18 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_SHQsD__V19dn_csDRt2Fx7uq8opnkpDCQqQ1MDv4KAQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).