From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35351) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akwI6-0005MI-1O for qemu-devel@nongnu.org; Tue, 29 Mar 2016 12:14:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akwI5-0002ZU-8x for qemu-devel@nongnu.org; Tue, 29 Mar 2016 12:14:49 -0400 Received: from mail-vk0-x235.google.com ([2607:f8b0:400c:c05::235]:35156) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akwI5-0002ZP-2h for qemu-devel@nongnu.org; Tue, 29 Mar 2016 12:14:49 -0400 Received: by mail-vk0-x235.google.com with SMTP id e6so24877130vkh.2 for ; Tue, 29 Mar 2016 09:14:48 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1458900629-2334-2-git-send-email-famz@redhat.com> References: <1458900629-2334-1-git-send-email-famz@redhat.com> <1458900629-2334-2-git-send-email-famz@redhat.com> From: Peter Maydell Date: Tue, 29 Mar 2016 17:14:28 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 1/2] memory: Remove code for mr->may_overlap List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Paolo Bonzini , QEMU Developers On 25 March 2016 at 10:10, Fam Zheng wrote: > The collision check does nothing and hasn't been used. Remove the > variable together with related code. > > Signed-off-by: Fam Zheng I would prefer it if we enabled the collision check and fixed the things which weren't specifying overlap priorities. thanks -- PMM