From: Peter Maydell <peter.maydell@linaro.org>
To: Thomas Huth <thuth@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Eric Blake <eblake@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] configure: Add a proper check for openpty() in libutil
Date: Thu, 17 Jan 2019 18:07:34 +0000 [thread overview]
Message-ID: <CAFEAcA_TSSCUGXO-ze6QBfZsiddszywBCMgrX=kYjORwJsrdbA@mail.gmail.com> (raw)
In-Reply-To: <1547745248-1750-1-git-send-email-thuth@redhat.com>
On Thu, 17 Jan 2019 at 17:14, Thomas Huth <thuth@redhat.com> wrote:
>
> On Linux (and maybe some BSDs), we require libutil for the openpty()
> function. However, this library is not available on some other systems, so
> we currently use a fragile if-statement in the configure script to check
> whether we need the library or not. Unfortunately, we also hard-coded a
> "-lutil" in the tests/Makefile.include file, so this breaks the build on
> Solaris, for example (see buglink below). To fix the issue, add the "-lutil"
> to "libs_tools" in the configure script instead, then this gets properly
> propagated to the tests, too.
It also gets propagated to every tool binary we build even if
it doesn't use openpty(), but I guess that's not a big deal.
thanks
-- PMM
next prev parent reply other threads:[~2019-01-17 18:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 17:14 [Qemu-devel] [PATCH] configure: Add a proper check for openpty() in libutil Thomas Huth
2019-01-17 17:34 ` Philippe Mathieu-Daudé
2019-01-17 17:39 ` Eric Blake
2019-01-17 17:53 ` Paolo Bonzini
2019-01-17 18:07 ` Peter Maydell [this message]
2019-01-17 18:15 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA_TSSCUGXO-ze6QBfZsiddszywBCMgrX=kYjORwJsrdbA@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).