From: Peter Maydell <peter.maydell@linaro.org>
To: FelixYao <felix.yzg@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1/1] main loop: remove useless code
Date: Sat, 2 Dec 2017 11:52:38 +0000 [thread overview]
Message-ID: <CAFEAcA_VZVcbS9JhorMa9SnTkO+j5uL4LFZ91vBsVqemVFUHRA@mail.gmail.com> (raw)
In-Reply-To: <1512200490-50021-1-git-send-email-felix.yzg@gmail.com>
On 2 December 2017 at 07:41, FelixYao <felix.yzg@gmail.com> wrote:
> hi Paolo Bonzini:
>
> Those codes seem useless, Could it be removed?
>
> Signed-off-by: FelixYao <felix.yzg@gmail.com>
> ---
> vl.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 1ad1c04..5bed4c2 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2995,10 +2995,6 @@ static void set_memory_options(uint64_t *ram_slots, ram_addr_t *maxram_size,
>
> sz = QEMU_ALIGN_UP(sz, 8192);
> ram_size = sz;
> - if (ram_size != sz) {
> - error_report("ram size too large");
> - exit(EXIT_FAILURE);
> - }
ram_size is a ramaddr_t, which may be a 32-bit variable, whereas
sz is a uint64_t. This check is making sure that the ram size
specified can actually fit in a ramaddr_t.
thanks
-- PMM
next prev parent reply other threads:[~2017-12-02 11:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-02 7:41 [Qemu-devel] [PATCH 1/1] main loop: remove useless code FelixYao
2017-12-02 11:52 ` Peter Maydell [this message]
2017-12-04 2:08 ` felix yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_VZVcbS9JhorMa9SnTkO+j5uL4LFZ91vBsVqemVFUHRA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=felix.yzg@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).