From: Peter Maydell <peter.maydell@linaro.org>
To: liguang <lig.fnst@cn.fujitsu.com>
Cc: "Peter Crosthwaite" <peter.crosthwaite@xilinx.com>,
"Juan Quintela" <quintela@redhat.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH v11 3/5] hw/intc: add allwinner A10 interrupt controller
Date: Thu, 12 Dec 2013 19:11:33 +0000 [thread overview]
Message-ID: <CAFEAcA_Vt3Gbrjn85vdmqSZjPvy5-e5VTCPR1mqAx18HABtngg@mail.gmail.com> (raw)
In-Reply-To: <1386749341-9843-4-git-send-email-lig.fnst@cn.fujitsu.com>
On 11 December 2013 08:08, liguang <lig.fnst@cn.fujitsu.com> wrote:
> +static void aw_a10_pic_set_irq(void *opaque, int irq, int level)
> +{
> + AwA10PICState *s = opaque;
> +
> + if (level) {
> + set_bit(irq%32, (void *)&s->irq_pending[irq/32]);
The % and / operators here should have spaces round them.
> + }
> + aw_a10_pic_update(s);
> +}
> +
> +static uint64_t aw_a10_pic_read(void *opaque, hwaddr offset, unsigned size)
> +{
> + AwA10PICState *s = opaque;
> + uint8_t index = (offset & 0xc)/4;
Spaces.
Otherwise
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
-- PMM
next prev parent reply other threads:[~2013-12-12 19:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 8:08 [Qemu-devel] [PATCH v11 0/5] add allwinner A10 SoC support liguang
2013-12-11 8:08 ` [Qemu-devel] [PATCH v11 1/5] vmstate: add VMSTATE_PTIMER_ARRAY liguang
2013-12-12 8:59 ` Li Guang
2013-12-12 19:57 ` Peter Maydell
2013-12-13 0:43 ` Li Guang
2013-12-11 8:08 ` [Qemu-devel] [PATCH v11 2/5] hw/timer: add allwinner a10 timer liguang
2013-12-11 8:08 ` [Qemu-devel] [PATCH v11 3/5] hw/intc: add allwinner A10 interrupt controller liguang
2013-12-11 8:27 ` Peter Crosthwaite
2013-12-12 19:09 ` Peter Maydell
2013-12-12 19:11 ` Peter Maydell [this message]
2013-12-13 0:43 ` Li Guang
2013-12-11 8:09 ` [Qemu-devel] [PATCH v11 4/5] hw/arm: add allwinner a10 SoC support liguang
2013-12-11 8:09 ` [Qemu-devel] [PATCH v11 5/5] hw/arm: add cubieboard support liguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_Vt3Gbrjn85vdmqSZjPvy5-e5VTCPR1mqAx18HABtngg@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=afaerber@suse.de \
--cc=lig.fnst@cn.fujitsu.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).