qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Patch Tracking <patches@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] qga/commands-posix.c: Use correct types with g_base64_decode()
Date: Tue, 14 Apr 2015 15:36:18 +0100	[thread overview]
Message-ID: <CAFEAcA_VzybniZnpbYmNmvt3KP6=mhBPy8hG5od_p4-nxvxg9Q@mail.gmail.com> (raw)
In-Reply-To: <552D2451.5040403@redhat.com>

On 14 April 2015 at 15:29, Paolo Bonzini <pbonzini@redhat.com> wrote:
> If anything, I would add a QEMU_BUILD_BUG_ON(sizeof(gsize) !=
> sizeof(size_t)) to catch the problem, since we've had many experienced
> developers caught unprepared.

...put it in configure, since it's a configuration error?

-- PMM

      parent reply	other threads:[~2015-04-14 14:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-08 20:02 [Qemu-devel] [PATCH] qga/commands-posix.c: Use correct types with g_base64_decode() Peter Maydell
2015-04-08 20:14 ` Michael Roth
2015-04-14 13:38 ` Thomas Huth
2015-04-14 13:41   ` Peter Maydell
2015-04-14 14:30     ` Paolo Bonzini
2015-04-14 13:42 ` Paolo Bonzini
2015-04-14 13:45   ` Peter Maydell
2015-04-14 14:29     ` Paolo Bonzini
2015-04-14 14:35       ` Eric Blake
2015-04-14 14:50         ` Paolo Bonzini
2015-04-14 15:12           ` Eric Blake
2015-04-14 14:36       ` Peter Maydell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA_VzybniZnpbYmNmvt3KP6=mhBPy8hG5od_p4-nxvxg9Q@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=patches@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).