qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, anjo@rev.ng,
	"Richard Henderson" <richard.henderson@linaro.org>,
	alex.bennee@linaro.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	kvm@vger.kernel.org, "Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH v7 00/49] single-binary: compile target/arm twice
Date: Mon, 12 May 2025 18:05:25 +0100	[thread overview]
Message-ID: <CAFEAcA_WtAAba9QBS_zOPUPtjdeDv+0mDJiTEepHS2+61aZERA@mail.gmail.com> (raw)
In-Reply-To: <726ecb14-fa2e-4692-93a2-5e6cc277c0c2@linaro.org>

On Mon, 12 May 2025 at 17:53, Pierrick Bouvier
<pierrick.bouvier@linaro.org> wrote:
>
> Hi Peter,
>
> On 5/11/25 6:40 AM, Peter Maydell wrote:
> > On Thu, 8 May 2025 at 00:42, Pierrick Bouvier
> > <pierrick.bouvier@linaro.org> wrote:
> >>
> >> More work toward single-binary.
> >>
> >> Some files have external dependencies for the single-binary:
> >> - target/arm/gdbstub.c: gdbhelpers
> >> - target/arm/arm-qmp-cmds.c: qapi
> >> - target/arm/tcg/translate*: need deep cleanup in include/tcg
> >> - target/arm/tcg/cpu*: need TargetInfo implemented for arm/aarch64
> >> - target/arm/tcg/*-helper*: need deeper split between aarch64 and arm code
> >> They will not be ported in this series.
> >>
> >> Built on {linux, windows, macos} x {x86_64, aarch64}
> >> Fully tested on linux x {x86_64, aarch64}
> >>
> >> Series is now tested and fully reviewed. Thanks for pulling it.
> >
> > Do you/Philippe have a plan for how you want this to go into
> > the tree? I know Philippe has been taking a lot of the
> > single-binary related patches. Let me know if you want me
> > to pick it up via target-arm.
> >
>
> During the release code freeze, we mostly used tcg-next.
> However, now everything is back to normal, we simply work upstream, with
> a simple "first pulled, first in" strategy, fixing the occasional
> conflicts on our respective sides.
>
> So if you could pull this, that would be appreciated.

I had a go, but it seems to depend on some other patch
or series that isn't in upstream git yet. Specifically,
the changes to include/system/hvf.h assume it has an
include of "cpu.h": you can see it in the context in
patch 2:
https://lore.kernel.org/qemu-devel/20250507234241.957746-3-pierrick.bouvier@linaro.org/
but that include isn't there in upstream git yet, so the
patches touching that file eventually fail to apply cleanly.
I assume that's "accel/hvf: Include missing 'hw/core/cpu.h' header",
but is there anything else this series was based on?

thanks
-- PMM


  reply	other threads:[~2025-05-12 17:06 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-07 23:41 [PATCH v7 00/49] single-binary: compile target/arm twice Pierrick Bouvier
2025-05-07 23:41 ` [PATCH v7 01/49] target/arm: Replace target_ulong -> vaddr for HWBreakpoint Pierrick Bouvier
2025-05-07 23:41 ` [PATCH v7 02/49] include/system/hvf: missing vaddr include Pierrick Bouvier
2025-05-07 23:41 ` [PATCH v7 03/49] meson: add common libs for target and target_system Pierrick Bouvier
2025-05-07 23:41 ` [PATCH v7 04/49] target/arm: move kvm stubs and remove CONFIG_KVM from kvm_arm.h Pierrick Bouvier
2025-05-07 23:41 ` [PATCH v7 05/49] target/arm/kvm-stub: add kvm_arm_reset_vcpu stub Pierrick Bouvier
2025-05-07 23:41 ` [PATCH v7 06/49] target/arm/cpu: move arm_cpu_kvm_set_irq to kvm.c Pierrick Bouvier
2025-05-07 23:41 ` [PATCH v7 07/49] accel/hvf: add hvf_enabled() for common code Pierrick Bouvier
2025-05-07 23:41 ` [PATCH v7 08/49] target/arm/cpu: remove TARGET_BIG_ENDIAN dependency Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 09/49] target/arm/cpu: remove TARGET_AARCH64 around aarch64_cpu_dump_state common Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 10/49] target/arm/cpu: remove TARGET_AARCH64 in arm_cpu_finalize_features Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 11/49] target/arm/cpu: compile file twice (user, system) only Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 12/49] target/arm/cpu32-stubs.c: compile file twice (user, system) Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 13/49] tcg: add vaddr type for helpers Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 14/49] target/arm/helper: use vaddr instead of target_ulong for exception_pc_alignment Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 15/49] target/arm/helper: use vaddr instead of target_ulong for probe_access Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 16/49] target/arm/helper: extract common helpers Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 17/49] target/arm/debug_helper: only include " Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 18/49] target/arm/debug_helper: remove target_ulong Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 19/49] target/arm/debug_helper: compile file twice (user, system) Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 20/49] target/arm/helper: restrict include to common helpers Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 21/49] target/arm/helper: replace target_ulong by vaddr Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 22/49] target/arm/helper: expose aarch64 cpu registration Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 23/49] target/arm/helper: remove remaining TARGET_AARCH64 Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 24/49] target/arm/helper: compile file twice (user, system) Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 25/49] target/arm/vfp_fpscr: " Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 26/49] target/arm/arch_dump: remove TARGET_AARCH64 conditionals Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 27/49] target/arm/arch_dump: compile file once (system) Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 28/49] target/arm/arm-powerctl: " Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 29/49] target/arm/cortex-regs: " Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 30/49] target/arm/ptw: replace target_ulong with int64_t Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 31/49] target/arm/ptw: replace TARGET_AARCH64 by CONFIG_ATOMIC64 from arm_casq_ptw Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 32/49] target/arm/ptw: compile file once (system) Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 33/49] target/arm/meson: accelerator files are not needed in user mode Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 34/49] target/arm/kvm-stub: compile file once (system) Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 35/49] target/arm/machine: reduce migration include to avoid target specific definitions Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 36/49] target/arm/machine: remove TARGET_AARCH64 from migration state Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 37/49] target/arm/machine: move cpu_post_load kvm bits to kvm_arm_cpu_post_load function Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 38/49] target/arm/kvm-stub: add missing stubs Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 39/49] target/arm/machine: compile file once (system) Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 40/49] target/arm/tcg/vec_internal: use forward declaration for CPUARMState Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 41/49] target/arm/tcg/crypto_helper: compile file once Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 42/49] target/arm/tcg/hflags: compile file twice (system, user) Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 43/49] target/arm/tcg/iwmmxt_helper: " Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 44/49] target/arm/tcg/neon_helper: " Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 45/49] target/arm/tcg/tlb_helper: " Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 46/49] target/arm/helper: restrict define_tlb_insn_regs to system target Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 47/49] target/arm/tcg/tlb-insns: compile file once (system) Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 48/49] target/arm/tcg/arith_helper: compile file once Pierrick Bouvier
2025-05-07 23:42 ` [PATCH v7 49/49] target/arm/tcg/vfp_helper: compile file twice (system, user) Pierrick Bouvier
2025-05-11 13:40 ` [PATCH v7 00/49] single-binary: compile target/arm twice Peter Maydell
2025-05-12 16:53   ` Pierrick Bouvier
2025-05-12 17:05     ` Peter Maydell [this message]
2025-05-12 18:10       ` Pierrick Bouvier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA_WtAAba9QBS_zOPUPtjdeDv+0mDJiTEepHS2+61aZERA@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=anjo@rev.ng \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=pierrick.bouvier@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).