From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F02FFC433E0 for ; Thu, 11 Mar 2021 17:11:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B59164F31 for ; Thu, 11 Mar 2021 17:11:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B59164F31 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48782 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKOqE-0006lo-95 for qemu-devel@archiver.kernel.org; Thu, 11 Mar 2021 12:11:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57510) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKOhv-0005dX-34 for qemu-devel@nongnu.org; Thu, 11 Mar 2021 12:02:43 -0500 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]:44948) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lKOhm-0002Ij-Kg for qemu-devel@nongnu.org; Thu, 11 Mar 2021 12:02:42 -0500 Received: by mail-ej1-x635.google.com with SMTP id ox4so32062926ejb.11 for ; Thu, 11 Mar 2021 09:02:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=boV5bAFWRlNeOWTRrUVrjfQz/GzZqixgUhKAHedJyL0=; b=kF8ab1mlBrK+ylVpMCqH7wAfwZzH6txqSv7kbZb+P6MpNk6LG4Qm5hCxBwxJLsjDUG 7kSgbUepYDilYSokj8S9F3dEGfDHP9wvzFcTjUHNKFJ8E8R433gDTZF5w2ZuKXYYF8Ho tFMd20gnL8ZEKAniZp6kBer27HiVBxtkwUeGeT0I3B3uyU5Usdgwb3ysDRtiTm/loUT2 v9Xo23DjOier7818RFh2FZMtLmTkFPTyBD9ieSPjTi/t6DrenrIkDzMsF0i5/2xLbLar hRrS3GzTwGvy3pCe/VYW6HedGmpBI1SyeVmuRyXmJnU00omvBGxWtX00HD+l0qozZyZ2 61fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=boV5bAFWRlNeOWTRrUVrjfQz/GzZqixgUhKAHedJyL0=; b=S7gcFkTxTFUoRDfxWThjtdlgiuYwdTD7GxJDnagyiAldOwbS1QTGM8fPFWe2Y9u40n OW1hqAvK/DWWdTyCE1OesWEPrJ5/VLZ9yjmEbFKbTo5/PAEpHRgTUdqLF/JOLSWzBubl I1k2U1dEtQz53mi2+v8cJSTajWoycflnKNOPBg1+sePNyWF3Ur4ASqXihlsrQdA7kaFA w9CkNk4u55y6tTJvYvhL1TO8lsXSlmK59UxkvxN8bJOwq9UTeILpxJKN/a0akIRMf8cr RsOz1CjmpHtF2FwI3Y9+HjGk1bFXOD1Os8vm3p9aie/c6IreuBa8Lg2GzZiWJp6o+qhL hfBg== X-Gm-Message-State: AOAM530/vbYHV3kiv8pDR/GbpWoLuUYGuTRvCugBk1K1FCsspXDS5QXF jQuNPJb7zba1D7jcQUFu64IHhgkQwdShjf0s/E7uRQ== X-Google-Smtp-Source: ABdhPJwExtmDbIclQ3jwYkD3qjl/wVYl4WJJFaSKgPerxZVuu+WRykWXE+6GMcPOItSoz7O/nov2WgtVpEhXh2xFswM= X-Received: by 2002:a17:906:b14d:: with SMTP id bt13mr3974573ejb.407.1615482148073; Thu, 11 Mar 2021 09:02:28 -0800 (PST) MIME-Version: 1.0 References: <20210303151634.3421880-1-marcin.juszkiewicz@linaro.org> <20210303174849.GF1664@vanye> <20210304135304.GI1664@vanye> <20210304152512.GJ1664@vanye> In-Reply-To: <20210304152512.GJ1664@vanye> From: Peter Maydell Date: Thu, 11 Mar 2021 17:02:09 +0000 Message-ID: Subject: Re: [PATCH] arm: bump amount of PMU counters to pass SBSA ACS To: Leif Lindholm Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::635; envelope-from=peter.maydell@linaro.org; helo=mail-ej1-x635.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marcin Juszkiewicz , qemu-arm , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 4 Mar 2021 at 15:25, Leif Lindholm wrote: > > On Thu, Mar 04, 2021 at 15:14:36 +0000, Peter Maydell wrote: > > On Thu, 4 Mar 2021 at 13:53, Leif Lindholm wrote: > > > > > > On Wed, Mar 03, 2021 at 18:06:46 +0000, Peter Maydell wrote: > > > > On Wed, 3 Mar 2021 at 17:48, Leif Lindholm wrote: > > > > > It would be good if we could get 6.0 closer to SBSA compliance. > > > > > > > > How far away are we at the moment ? > > > > > > > > > Would it be worth the effort to make this controllable per cpu model? > > > > > > > > I don't have a strong opinion on whether we should, but if we do then the > > > > right way to implement that would be to have the PMCR reset value > > > > as a reset_pmcr_el0 field in struct ARMCPU (like the existing reset_fpsid, > > > > reset_sctlr, etc) that gets set per-CPU to whatever the CPU's value for > > > > it is; and then instead of using a PMCR_NUM_COUNTERS value, > > > > extract the PMCR.N field when needed. The hardest part would be > > > > going through all the CPU TRMs to find out the correct reset value. > > > > > > That makes sense. > I'll throw this on my never-shrinking pile of things I hope to get > around to at some point. I just sent a patch that does it that way, though it is desperately in need of more testing. I'm currently on the fence about whether to put this patch or that one in for 6.0. thanks -- PMM