From: Peter Maydell <peter.maydell@linaro.org>
To: Michal Privoznik <mprivozn@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] linux-user: Rework __put_user and __get_user
Date: Tue, 3 Jun 2014 18:27:37 +0100 [thread overview]
Message-ID: <CAFEAcA_YJHWM2b4x-L++K1-tEJuVymSh5zU4-5Z14n54TotZdQ@mail.gmail.com> (raw)
In-Reply-To: <b2fae13a2270fb0c528d0e2853fe28500da175c0.1401812114.git.mprivozn@redhat.com>
On 3 June 2014 17:15, Michal Privoznik <mprivozn@redhat.com> wrote:
> With the latest gcc-4.9.0 I'm getting some compile errors:
>
> In file included from qemu.git/linux-user/syscall.c:113:0:
> qemu.git/linux-user/syscall.c: In function ‘copy_from_user_fdset’:
> qemu.git/linux-user/qemu.h:309:13: error: right-hand operand of comma expression has no effect [-Werror=unused-value]
> (hptr)), 0)
> ^
> qemu.git/linux-user/qemu.h:316:31: note: in expansion of macro ‘__get_user_e’
> # define __get_user(x, hptr) __get_user_e(x, hptr, le)
> ^
> qemu/qemu.git/linux-user/syscall.c:704:9: note: in expansion of macro ‘__get_user’
> __get_user(b, &target_fds[i]);
> ^
See this patchseries from Riku in April:
https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03528.html
thanks
-- PMM
prev parent reply other threads:[~2014-06-03 17:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 16:15 [Qemu-devel] [PATCH] linux-user: Rework __put_user and __get_user Michal Privoznik
2014-06-03 17:27 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_YJHWM2b4x-L++K1-tEJuVymSh5zU4-5Z14n54TotZdQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=mprivozn@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).