From: Peter Maydell <peter.maydell@linaro.org>
To: Mohamed Mediouni <mohamed@unpredictable.fr>
Cc: qemu-devel@nongnu.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Igor Mammedov" <imammedo@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Roman Bolshakov" <rbolshakov@ddn.com>,
"Phil Dennis-Jordan" <phil@philjordan.eu>,
"Ani Sinha" <anisinha@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Alexander Graf" <agraf@csgraf.de>,
"Mads Ynddal" <mads@ynddal.dk>,
"Sunil Muthuswamy" <sunilmut@microsoft.com>,
"Zhao Liu" <zhao1.liu@intel.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Cameron Esfahani" <dirty@apple.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Shannon Zhao" <shannon.zhaosl@gmail.com>,
qemu-arm@nongnu.org, "Yanan Wang" <wangyanan55@huawei.com>,
"Pierrick Bouvier" <pierrick.bouvier@linaro.org>
Subject: Re: [PATCH v5 08/18] whpx: interrupt controller support
Date: Tue, 19 Aug 2025 16:04:09 +0100 [thread overview]
Message-ID: <CAFEAcA_ZokV90NRuWY7PGgk_Jwh-ZfZfNO+Ubss0F8AWDBTwoQ@mail.gmail.com> (raw)
In-Reply-To: <20250808065419.47415-9-mohamed@unpredictable.fr>
On Fri, 8 Aug 2025 at 07:54, Mohamed Mediouni <mohamed@unpredictable.fr> wrote:
>
> Signed-off-by: Mohamed Mediouni <mohamed@unpredictable.fr>
>
> Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> +static void whpx_gicv3_put_cpu(CPUState *cpu_state, run_on_cpu_data arg)
> +{
> +}
> +
> +static void whpx_gicv3_put(GICv3State *s)
> +{
> + int ncpu;
> +
> + whpx_gicv3_check(s);
> +
> + for (ncpu = 0; ncpu < s->num_cpu; ncpu++) {
> + run_on_cpu_data data;
> + data.host_ptr = &s->cpu[ncpu];
> + run_on_cpu(s->cpu[ncpu].cpu, whpx_gicv3_put_cpu, data);
> + }
Why are we calling run_on_cpu() and telling it to do nothing?
Also, run_on_cpu() implicitly drops the big kernel lock --
I'm not sure that is valid to do from the pre-save/post-load
routines or in a reset handler.
thanks
-- PMM
next prev parent reply other threads:[~2025-08-19 15:05 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-08 6:54 [PATCH v5 00/18] WHPX support for Arm Mohamed Mediouni
2025-08-08 6:54 ` [PATCH v5 01/18] accel/system: Introduce hwaccel_enabled() helper Mohamed Mediouni
2025-08-08 6:54 ` [PATCH v5 02/18] hw/arm: virt: add GICv2m for the case when ITS is not available Mohamed Mediouni
2025-08-19 13:04 ` Peter Maydell
2025-08-19 13:10 ` Peter Maydell
2025-08-08 6:54 ` [PATCH v5 03/18] whpx: Move around files before introducing AArch64 support Mohamed Mediouni
2025-08-08 6:54 ` [PATCH v5 04/18] whpx: reshuffle common code Mohamed Mediouni
2025-08-08 6:54 ` [PATCH v5 05/18] whpx: ifdef out winhvemulation on non-x86_64 Mohamed Mediouni
2025-09-04 12:05 ` Bernhard Beschow
2025-08-08 6:54 ` [PATCH v5 06/18] whpx: common: add WHPX_INTERCEPT_DEBUG_TRAPS define Mohamed Mediouni
2025-08-08 6:54 ` [PATCH v5 07/18] hw, target, accel: whpx: change apic_in_platform to kernel_irqchip Mohamed Mediouni
2025-08-08 20:45 ` Philippe Mathieu-Daudé
2025-08-08 6:54 ` [PATCH v5 08/18] whpx: interrupt controller support Mohamed Mediouni
2025-08-19 15:04 ` Peter Maydell [this message]
2025-08-08 6:54 ` [PATCH v5 09/18] whpx: add arm64 support Mohamed Mediouni
2025-08-08 6:54 ` [PATCH v5 10/18] whpx: copy over memory management logic from hvf Mohamed Mediouni
2025-08-08 6:54 ` [PATCH v5 11/18] target/arm: cpu: mark WHPX as supporting PSCI 1.1 Mohamed Mediouni
2025-08-08 20:53 ` Philippe Mathieu-Daudé
2025-08-08 6:54 ` [PATCH v5 12/18] hw/arm: virt: cleanly fail on attempt to use the platform vGIC together with ITS Mohamed Mediouni
2025-08-08 6:54 ` [PATCH v5 13/18] whpx: arm64: clamp down IPA size Mohamed Mediouni
2025-08-08 6:54 ` [PATCH v5 14/18] hw/arm, accel/hvf, whpx: unify get_physical_address_range between WHPX and HVF Mohamed Mediouni
2025-08-08 6:54 ` [PATCH v5 15/18] whpx: arm64: implement -cpu host Mohamed Mediouni
2025-08-19 13:24 ` Peter Maydell
2025-08-19 15:04 ` Pierrick Bouvier
2025-08-19 15:06 ` Peter Maydell
2025-08-19 15:12 ` Daniel P. Berrangé
2025-08-19 15:48 ` Pierrick Bouvier
2025-08-19 16:08 ` Daniel P. Berrangé
2025-08-19 16:25 ` Pierrick Bouvier
2025-08-19 16:40 ` Daniel P. Berrangé
2025-08-19 16:58 ` Pierrick Bouvier
2025-08-08 6:54 ` [PATCH v5 16/18] target/arm: whpx: instantiate GIC early Mohamed Mediouni
2025-08-08 6:54 ` [PATCH v5 17/18] whpx: arm64: gicv3: add migration blocker Mohamed Mediouni
2025-08-08 16:14 ` Pierrick Bouvier
2025-08-19 13:13 ` Peter Maydell
2025-08-08 6:54 ` [PATCH v5 18/18] MAINTAINERS: Add myself as a maintainer for WHPX Mohamed Mediouni
2025-08-08 21:02 ` Philippe Mathieu-Daudé
2025-09-04 12:01 ` [PATCH v5 00/18] WHPX support for Arm Bernhard Beschow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_ZokV90NRuWY7PGgk_Jwh-ZfZfNO+Ubss0F8AWDBTwoQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=agraf@csgraf.de \
--cc=anisinha@redhat.com \
--cc=berrange@redhat.com \
--cc=dirty@apple.com \
--cc=eduardo@habkost.net \
--cc=imammedo@redhat.com \
--cc=mads@ynddal.dk \
--cc=marcandre.lureau@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mohamed@unpredictable.fr \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=phil@philjordan.eu \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rbolshakov@ddn.com \
--cc=richard.henderson@linaro.org \
--cc=shannon.zhaosl@gmail.com \
--cc=sunilmut@microsoft.com \
--cc=wangyanan55@huawei.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).