From: Peter Maydell <peter.maydell@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [PATCH] tcg: Fix info_in_idx increment in layout_arg_by_ref
Date: Thu, 13 Jul 2023 13:37:31 +0100 [thread overview]
Message-ID: <CAFEAcA__75U_DmeNT8n+yBaR8jfKynMoToWhMj6Wb2VorNS6aA@mail.gmail.com> (raw)
In-Reply-To: <20230707102955.5607-1-richard.henderson@linaro.org>
On Fri, 7 Jul 2023 at 11:29, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Off by one error, failing to take into account that layout_arg_1
> already incremeneted info_in_idx for the first piece. We only
> need care for the n-1 TCG_CALL_ARG_BY_REF_N pieces here.
>
> Cc: qemu-stable@nongnu.org
> Fixes: 313bdea84d2 ("tcg: Add TCG_CALL_{RET,ARG}_BY_REF")
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1751
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
Tested-by: Peter Maydell <peter.maydell@linaro.org>
-- PMM
prev parent reply other threads:[~2023-07-13 12:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 10:29 [PATCH] tcg: Fix info_in_idx increment in layout_arg_by_ref Richard Henderson
2023-07-07 13:29 ` Philippe Mathieu-Daudé
2023-07-07 13:30 ` Philippe Mathieu-Daudé
2023-07-13 12:37 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA__75U_DmeNT8n+yBaR8jfKynMoToWhMj6Wb2VorNS6aA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).