From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37442) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwqRP-0004iR-Q7 for qemu-devel@nongnu.org; Thu, 12 Nov 2015 06:53:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwqRO-0001eB-NK for qemu-devel@nongnu.org; Thu, 12 Nov 2015 06:53:23 -0500 Received: from mail-vk0-x22c.google.com ([2607:f8b0:400c:c05::22c]:36831) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwqRO-0001dz-JD for qemu-devel@nongnu.org; Thu, 12 Nov 2015 06:53:22 -0500 Received: by vkbs1 with SMTP id s1so8429255vkb.3 for ; Thu, 12 Nov 2015 03:53:22 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1447165546-27784-43-git-send-email-quintela@redhat.com> References: <1447165546-27784-1-git-send-email-quintela@redhat.com> <1447165546-27784-43-git-send-email-quintela@redhat.com> From: Peter Maydell Date: Thu, 12 Nov 2015 11:53:02 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PULL 42/57] Page request: Consume pages off the post-copy queue List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: Amit Shah , QEMU Developers , "Dr. David Alan Gilbert" On 10 November 2015 at 14:25, Juan Quintela wrote: > From: "Dr. David Alan Gilbert" > > When transmitting RAM pages, consume pages that have been queued by > MIG_RPCOMM_REQPAGE commands and send them ahead of normal page scanning. > > Note: > a) After a queued page the linear walk carries on from after the > unqueued page; there is a reasonable chance that the destination > was about to ask for other closeby pages anyway. > > b) We have to be careful of any assumptions that the page walking > code makes, in particular it does some short cuts on its first linear > walk that break as soon as we do a queued page. > > c) We have to be careful to not break up host-page size chunks, since > this makes it harder to place the pages on the destination. > > Signed-off-by: Dr. David Alan Gilbert > Reviewed-by: Juan Quintela > Signed-off-by: Juan Quintela I've just discovered that this is causing 'make check' failures on my OSX host (unfortunately something in my setup is causing 'make check' failures to not always cause a build failure, so I didn't notice earlier): manooth$ (make -C build/x86 -j8 && cd build/x86 && QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 QTEST_QEMU_IMG=qemu-img MALLOC_PERTURB_=${MALLOC_PERTURB_:-$((RANDOM % 255 + 1))} tests/ahci-test) [...] /x86_64/ahci/flush/simple: OK /x86_64/ahci/flush/retry: OK /x86_64/ahci/flush/migrate: qemu: qemu_mutex_lock: Invalid argument qemu-system-x86_64:Broken pipe Not a migration stream qemu-system-x86_64: load of migration failed: Invalid argument thanks -- PMM