From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47276) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZgeHt-0006i9-SV for qemu-devel@nongnu.org; Mon, 28 Sep 2015 15:40:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZgeHq-0006zS-EH for qemu-devel@nongnu.org; Mon, 28 Sep 2015 15:40:37 -0400 Received: from mail-vk0-f53.google.com ([209.85.213.53]:34882) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZgeHq-0006zM-BS for qemu-devel@nongnu.org; Mon, 28 Sep 2015 15:40:34 -0400 Received: by vkao3 with SMTP id o3so89779242vka.2 for ; Mon, 28 Sep 2015 12:40:34 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <87lhbq1glx.fsf@blackfin.pond.sub.org> References: <1443121042-3409-1-git-send-email-armbru@redhat.com> <1443121042-3409-7-git-send-email-armbru@redhat.com> <56054E5E.3090005@redhat.com> <87y4fu1t3j.fsf@blackfin.pond.sub.org> <560590A6.3030408@redhat.com> <87io6vm08l.fsf@blackfin.pond.sub.org> <560905C5.2030209@redhat.com> <87fv1ybohq.fsf@blackfin.pond.sub.org> <87lhbq1glx.fsf@blackfin.pond.sub.org> From: Peter Maydell Date: Mon, 28 Sep 2015 20:40:14 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v3 6/7] qdev: Protect device-list-properties against broken devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Alexander Graf , Thomas Huth , Eduardo Habkost , Peter Crosthwaite , QEMU Developers , qemu-stable , Christian Borntraeger , "qemu-ppc@nongnu.org" , Antony Pavlov , Stefan Hajnoczi , Cornelia Huck , Paolo Bonzini , Alistair Francis , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Li Guang , Richard Henderson On 28 September 2015 at 20:36, Markus Armbruster wrote: > 1. I made device-introspection-test run "info qom-tree", which has a > lovely propensity to crash when a crappy device left dangling pointer > behind. This led me to "cgthree", "cuda", "integrator_debug", > "macio-oldworld", "macio-newworld", "pxa2xx-fir", "SUNW,tcx". They > all create memory regions without owner in their instance_init() > method. I guess these are all just "oops, we forgot to pass the Object* in instead of NULL" bugs rather than more difficult fixes. -- PMM