From: Peter Maydell <peter.maydell@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-arm <qemu-arm@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Luc Michel <luc.michel@greensocs.com>
Subject: Re: [PATCH] hw/arm/pxa2xx: rebuild hflags cache when modifying CPU state
Date: Tue, 5 Nov 2019 20:27:59 +0000 [thread overview]
Message-ID: <CAFEAcA__axmxsKL6NPYbGBMLS+YZ-aKNntn9hkSSg3nQR9Ksnw@mail.gmail.com> (raw)
In-Reply-To: <aff8e672-e0c7-a0f5-9c53-403a2e57524d@linaro.org>
On Tue, 5 Nov 2019 at 11:20, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> On 11/1/19 11:42 AM, Peter Maydell wrote:
> > The other place that might need checking is the PSCI/etc
> > code for doing CPU power on/off (and other callers to the
> > power up/down functions like the imx6 power control regs).
> > Richard, did you look at that code to see if it needed hflags updates?
>
> I had a quick grovel through hw/misc/imx6_src.c and didn't see anything; was
> there something more specific you were thinking of?
Not anything all that specific, but all the power-on/off
code is basically doing "change the state of this other
CPU by mangling its register state/etc". I forget how much
of this we do in common code and how much in the calling
code that handles the specifics of ACPI/imx6/etc.
thanks
-- PMM
next prev parent reply other threads:[~2019-11-05 20:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 10:32 [PATCH] hw/arm/pxa2xx: rebuild hflags cache when modifying CPU state Luc Michel
2019-11-01 10:42 ` Peter Maydell
2019-11-01 10:54 ` Luc Michel
2019-11-05 11:20 ` Richard Henderson
2019-11-05 20:27 ` Peter Maydell [this message]
2019-11-01 12:01 ` no-reply
2019-11-01 12:09 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA__axmxsKL6NPYbGBMLS+YZ-aKNntn9hkSSg3nQR9Ksnw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=luc.michel@greensocs.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).