From: Peter Maydell <peter.maydell@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org,
gustavo.romero@linaro.org, qemu-stable@nongnu.org
Subject: Re: [PATCH v3 2/6] target/arm: Fix nregs computation in do_{ld, st}_zpa
Date: Thu, 8 Feb 2024 16:24:01 +0000 [thread overview]
Message-ID: <CAFEAcA_aVb0a3=fxijwwrQChXZ1MXRVyx9ChCHSDMEjQcMYrsg@mail.gmail.com> (raw)
In-Reply-To: <20240207025210.8837-3-richard.henderson@linaro.org>
On Wed, 7 Feb 2024 at 02:53, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> The field is encoded as [0-3], which is convenient for
> indexing our array of function pointers, but the true
> value is [1-4]. Adjust before calling do_mem_zpa.
>
> Add an assert, and move the comment re passing ZT to
> the helper back next to the relevant code.
>
> Cc: qemu-stable@nongnu.org
> Fixes: 206adacfb8d ("target/arm: Add mte helpers for sve scalar + int loads")
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
next prev parent reply other threads:[~2024-02-08 16:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 2:52 [PATCH v3 0/6] target/arm: assorted mte fixes Richard Henderson
2024-02-07 2:52 ` [PATCH v3 1/6] linux-user/aarch64: Choose SYNC as the preferred MTE mode Richard Henderson
2024-02-07 20:03 ` Gustavo Romero
2024-02-08 16:18 ` Peter Maydell
2024-02-07 2:52 ` [PATCH v3 2/6] target/arm: Fix nregs computation in do_{ld,st}_zpa Richard Henderson
2024-02-08 16:24 ` Peter Maydell [this message]
2024-02-07 2:52 ` [PATCH v3 3/6] target/arm: Adjust and validate mtedesc sizem1 Richard Henderson
2024-02-16 15:12 ` Michael Tokarev
2024-02-16 19:17 ` Richard Henderson
2024-02-07 2:52 ` [PATCH v3 4/6] target/arm: Split out make_svemte_desc Richard Henderson
2024-02-07 2:52 ` [PATCH v3 5/6] target/arm: Handle mte in do_ldrq, do_ldro Richard Henderson
2024-02-07 2:52 ` [PATCH v3 6/6] target/arm: Fix SVE/SME gross MTE suppression checks Richard Henderson
2024-02-07 20:09 ` [PATCH v3 0/6] target/arm: assorted mte fixes Gustavo Romero
2024-02-08 16:27 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA_aVb0a3=fxijwwrQChXZ1MXRVyx9ChCHSDMEjQcMYrsg@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=gustavo.romero@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).