From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47829)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1TbsT6-0007EP-KP
	for qemu-devel@nongnu.org; Fri, 23 Nov 2012 07:34:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1TbsT0-0003bl-Q6
	for qemu-devel@nongnu.org; Fri, 23 Nov 2012 07:34:52 -0500
Received: from mail-ie0-f173.google.com ([209.85.223.173]:40034)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1TbsT0-0003bh-La
	for qemu-devel@nongnu.org; Fri, 23 Nov 2012 07:34:46 -0500
Received: by mail-ie0-f173.google.com with SMTP id e13so3025485iej.4
	for <qemu-devel@nongnu.org>; Fri, 23 Nov 2012 04:34:46 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <20121123122941.GA29800@stefanha-thinkpad.redhat.com>
References: <1353595852-30776-1-git-send-email-fred.konrad@greensocs.com>
	<1353595852-30776-3-git-send-email-fred.konrad@greensocs.com>
	<20121123122941.GA29800@stefanha-thinkpad.redhat.com>
Date: Fri, 23 Nov 2012 12:34:45 +0000
Message-ID: <CAFEAcA_a_gocpeRObav5WoWRdHF4Fsb7BHeuAA2qytFhNHEy+A@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [RFC PATCH v2 2/3] virtio-pci : add a virtio-bus
	interface
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: aliguori@us.ibm.com, e.voevodin@samsung.com, mark.burton@greensocs.com, qemu-devel@nongnu.org, cornelia.huck@de.ibm.com, afaerber@suse.de, fred.konrad@greensocs.com

On 23 November 2012 12:29, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> On Thu, Nov 22, 2012 at 03:50:51PM +0100, fred.konrad@greensocs.com wrote:
>> +static const struct VirtioBusInfo virtio_bus_info = {
>> +    .init_cb = virtio_pci_init_cb,
>> +    .exit_cb = virtio_pci_exit_cb,
>> +
>> +    .virtio_bindings = {
>
> Eventually VirtIOBindings can probably be inlined into VirtioBusInfo.  I
> don't see a need for separate structs.

I agree. It might (or might not) be convenient to retain it
temporarily while converting all the transports, but
VirtIOBindings is part of the old code which we're trying
to refactor here, and I'd expect it to go away when we're done.

-- PMM