From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34826)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1XwGnk-0005MX-Jd
	for qemu-devel@nongnu.org; Wed, 03 Dec 2014 15:45:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1XwGnf-0006w1-KG
	for qemu-devel@nongnu.org; Wed, 03 Dec 2014 15:45:32 -0500
Received: from mail-la0-f47.google.com ([209.85.215.47]:50356)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1XwGnf-0006vd-77
	for qemu-devel@nongnu.org; Wed, 03 Dec 2014 15:45:27 -0500
Received: by mail-la0-f47.google.com with SMTP id hz20so13001128lab.6
	for <qemu-devel@nongnu.org>; Wed, 03 Dec 2014 12:45:25 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <547F71B0.4030801@codeaurora.org>
References: <1417590738-29072-1-git-send-email-csong84@gatech.edu>
	<547F71B0.4030801@codeaurora.org>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Wed, 3 Dec 2014 20:45:04 +0000
Message-ID: <CAFEAcA_bwD-mbLjteneXiUbX0xiUe_Hr_iXGcVB-u9BEHr8XpQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH] ARM64: support access to more performance
 registers in AA64 mode
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christopher Covington <cov@codeaurora.org>
Cc: Chengyu Song <csong84@gatech.edu>, QEMU Developers <qemu-devel@nongnu.org>

On 3 December 2014 at 20:25, Christopher Covington <cov@codeaurora.org> wrote:
> Hi Chengyu,
>
> On 12/03/2014 02:12 AM, Chengyu Song wrote:

>>      { .name = "PMINTENSET", .cp = 15, .crn = 9, .crm = 14, .opc1 = 0, .opc2 = 1,
>>        .access = PL1_RW,
>>        .fieldoffset = offsetof(CPUARMState, cp15.c9_pminten),
>>        .resetvalue = 0,
>>        .writefn = pmintenset_write, .raw_writefn = raw_write },
>> +    { .name = "PMINTENSET_EL1", .state = ARM_CP_STATE_AA64,
>> +      .opc0 = 3, .crn = 9, .crm = 14, .opc1 = 0, .opc2 = 1,
>> +      .access = PL1_RW,
>> +      .fieldoffset = offsetof(CPUARMState, cp15.c9_pminten),
>> +      .resetvalue = 0,
>> +      .writefn = pmintenset_write, .raw_writefn = raw_write },
>
> Again, should .type = ARM_CP_NO_MIGRATE be used as this shares a variable with
> PMINTSET?

I think in this case and PMINTENCLR you can actually share a
single STATE_BOTH regdef, since the crn/crm/opc encodings
line up. Generally we prefer to do that where it works out.

thanks
-- PMM