qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>, pkern@debian.org
Subject: Re: [Qemu-devel] [PATCH] memory: call begin, log_start and commit when registering a new listener
Date: Mon, 2 Nov 2015 12:30:50 +0000	[thread overview]
Message-ID: <CAFEAcA_c18sATx6sm4jZHS5uUr+hVKo2yBucJQ1_r5WsxFmvaw@mail.gmail.com> (raw)
In-Reply-To: <1446452651-18147-1-git-send-email-pbonzini@redhat.com>

On 2 November 2015 at 08:24, Paolo Bonzini <pbonzini@redhat.com> wrote:
> This ensures that cpu_reload_memory_map() is called as soon as
> tcg_cpu_address_space_init() is called, and before cpu->memory_dispatch
> is used.  qemu-system-s390x never changes the address spaces after
> tcg_cpu_address_space_init() is called, and thus tcg_commit() is never
> called.  This causes a SIGSEGV.
>
> Reported-by: Philipp Kern <pkern@debian.org>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Fixes: 0a1c71cec63e95f9b8d0dc96d049d2daa00c5210
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

This is how I expected the memory listener API to work when I wrote
the exec.c change, anyway :-)

thanks
-- PMM

      reply	other threads:[~2015-11-02 12:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-02  8:24 [Qemu-devel] [PATCH] memory: call begin, log_start and commit when registering a new listener Paolo Bonzini
2015-11-02 12:30 ` Peter Maydell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA_c18sATx6sm4jZHS5uUr+hVKo2yBucJQ1_r5WsxFmvaw@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=pkern@debian.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).