From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39901) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtEGV-0001ZC-A1 for qemu-devel@nongnu.org; Mon, 02 Nov 2015 07:31:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtEGU-0007xM-Hx for qemu-devel@nongnu.org; Mon, 02 Nov 2015 07:31:11 -0500 Received: from mail-vk0-x230.google.com ([2607:f8b0:400c:c05::230]:34851) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtEGU-0007xI-DN for qemu-devel@nongnu.org; Mon, 02 Nov 2015 07:31:10 -0500 Received: by vkfw189 with SMTP id w189so83895637vkf.2 for ; Mon, 02 Nov 2015 04:31:10 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1446452651-18147-1-git-send-email-pbonzini@redhat.com> References: <1446452651-18147-1-git-send-email-pbonzini@redhat.com> From: Peter Maydell Date: Mon, 2 Nov 2015 12:30:50 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH] memory: call begin, log_start and commit when registering a new listener List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: QEMU Developers , pkern@debian.org On 2 November 2015 at 08:24, Paolo Bonzini wrote: > This ensures that cpu_reload_memory_map() is called as soon as > tcg_cpu_address_space_init() is called, and before cpu->memory_dispatch > is used. qemu-system-s390x never changes the address spaces after > tcg_cpu_address_space_init() is called, and thus tcg_commit() is never > called. This causes a SIGSEGV. > > Reported-by: Philipp Kern > Cc: Peter Maydell > Fixes: 0a1c71cec63e95f9b8d0dc96d049d2daa00c5210 > Signed-off-by: Paolo Bonzini Reviewed-by: Peter Maydell This is how I expected the memory listener API to work when I wrote the exec.c change, anyway :-) thanks -- PMM