From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51703)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Z4P0Y-0006fs-LN
	for qemu-devel@nongnu.org; Mon, 15 Jun 2015 03:40:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Z4P0T-0006sS-Ny
	for qemu-devel@nongnu.org; Mon, 15 Jun 2015 03:40:38 -0400
Received: from mail-yk0-f170.google.com ([209.85.160.170]:34813)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Z4P0T-0006sO-J7
	for qemu-devel@nongnu.org; Mon, 15 Jun 2015 03:40:33 -0400
Received: by ykfl8 with SMTP id l8so49945741ykf.1
	for <qemu-devel@nongnu.org>; Mon, 15 Jun 2015 00:40:33 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <000801d0a73a$d6fbeac0$84f3c040$@samsung.com>
References: <02f601d0a1e6$90c7d630$b2578290$@samsung.com>
	<CAFEAcA_XSZruYsKLHZCu4NoebxJEaQCUVvGeAWa9XctEC9SD8A@mail.gmail.com>
	<000801d0a73a$d6fbeac0$84f3c040$@samsung.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 15 Jun 2015 08:40:12 +0100
Message-ID: <CAFEAcA_caciwu-n4mwUACuWCccOwysycbebmrfWuG_q6oURy9Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v4] Use Aff1 with mpidr
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Fedin <p.fedin@samsung.com>
Cc: Shlomo Pongratz <shlomo.pongratz@huawei.com>, Shlomo Pongratz <shlomopongratz@gmail.com>, QEMU Developers <qemu-devel@nongnu.org>

On 15 June 2015 at 08:13, Pavel Fedin <p.fedin@samsung.com> wrote:
>  Hello!
>
>> > +int arm_cpus_per_cluster = 8;
>>
>> This doesn't need to be global, it doesn't need to be exposed in
>> a header file, and it definitely doesn't need to be non-constant.
>> I suggest
>> #define ARM_CPUS_PER_CLUSTER 8
>
>  It was a #define in v3, but i decided to change this in order to
> allow machine models to request different topology as Igor suggested.

For machine models to specify topology we would need a property
or properties on the QOM object for the machine model to set,
not a global. (And we'd need to have the code to see if KVM
supported setting arbitrary MPIDR values, and fail if not.)

thanks
-- PMM