qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Richard Henderson <rth@twiddle.net>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] util/iov: Fix -O1 uninitialized variable warning
Date: Thu, 18 Jul 2013 17:36:20 +0100	[thread overview]
Message-ID: <CAFEAcA_crhJopBsB-cby8n2piKBh=5u+=xMoW+UrSUSUdsbM6g@mail.gmail.com> (raw)
In-Reply-To: <1374164088-13146-1-git-send-email-rth@twiddle.net>

On 18 July 2013 17:14, Richard Henderson <rth@twiddle.net> wrote:
> At -O2, code in the form
>
>   if (p) A; B; if (p) C;
>
> may be rearranged via "jump threading" into
>
>   if (p) { A; B; C; } else { B; }
>
> But at -O1 this doesn't happen and we -Werror out here on
> the "may be used uninitialized" orig_len.  Perform this transform
> by hand so that -O1 remains a viable debugging alternative.
>
> Signed-off-by: Richard Henderson <rth@twiddle.net>

This is the same issue fixed by this (reviewed but
never applied) patch from June, isn't it?

http://patchwork.ozlabs.org/patch/251410/

thanks
-- PMM

  reply	other threads:[~2013-07-18 16:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-18 16:14 [Qemu-devel] [PATCH] util/iov: Fix -O1 uninitialized variable warning Richard Henderson
2013-07-18 16:36 ` Peter Maydell [this message]
2013-07-18 17:09   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA_crhJopBsB-cby8n2piKBh=5u+=xMoW+UrSUSUdsbM6g@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).