From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59223) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzrC7-0005Uk-Rg for qemu-devel@nongnu.org; Thu, 18 Jul 2013 12:36:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UzrC5-0006J9-Pe for qemu-devel@nongnu.org; Thu, 18 Jul 2013 12:36:43 -0400 Received: from mail-la0-f49.google.com ([209.85.215.49]:45685) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzrC5-0006Ix-Iz for qemu-devel@nongnu.org; Thu, 18 Jul 2013 12:36:41 -0400 Received: by mail-la0-f49.google.com with SMTP id ea20so2640260lab.22 for ; Thu, 18 Jul 2013 09:36:40 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1374164088-13146-1-git-send-email-rth@twiddle.net> References: <1374164088-13146-1-git-send-email-rth@twiddle.net> From: Peter Maydell Date: Thu, 18 Jul 2013 17:36:20 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH] util/iov: Fix -O1 uninitialized variable warning List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org On 18 July 2013 17:14, Richard Henderson wrote: > At -O2, code in the form > > if (p) A; B; if (p) C; > > may be rearranged via "jump threading" into > > if (p) { A; B; C; } else { B; } > > But at -O1 this doesn't happen and we -Werror out here on > the "may be used uninitialized" orig_len. Perform this transform > by hand so that -O1 remains a viable debugging alternative. > > Signed-off-by: Richard Henderson This is the same issue fixed by this (reviewed but never applied) patch from June, isn't it? http://patchwork.ozlabs.org/patch/251410/ thanks -- PMM