From: Peter Maydell <peter.maydell@linaro.org>
To: Hu Tao <hutao@cn.fujitsu.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] configure: check for pixman-1 version
Date: Sun, 14 Sep 2014 19:23:20 -0700 [thread overview]
Message-ID: <CAFEAcA_dNUJb1L8sYrNv0e4U8gNaq_tNrGLkFG1gWAP2j-XWpA@mail.gmail.com> (raw)
In-Reply-To: <1410746038-10488-1-git-send-email-hutao@cn.fujitsu.com>
On 14 September 2014 18:53, Hu Tao <hutao@cn.fujitsu.com> wrote:
> commit a93a3af9 introduces use of PIXMAN_TYPE_RGBA, but it's only available
> in pixman >= 0.21.8. If pixman doesn't meet the version requirement, qemu
> will fail to build with following message:
>
> /home/hutao/qemu/ui/qemu-pixman.c: In function ‘qemu_pixelformat_from_pixman’:
> /home/hutao/qemu/ui/qemu-pixman.c:42: error: ‘PIXMAN_TYPE_RGBA’ undeclared (first use in this function)
> /home/hutao/qemu/ui/qemu-pixman.c:42: error: (Each undeclared identifier is reported only once
> /home/hutao/qemu/ui/qemu-pixman.c:42: error: for each function it appears in.)
>
> This patch fixes the problem by checking the pixman version.
This alone is not sufficient, because the version of pixman
we have in our submodule is only 0.18.4. We also need to
bump that if we want to use newer versions (and to note
the increased dependency in our release notes next time
round).
thanks
-- PMM
next prev parent reply other threads:[~2014-09-15 2:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 1:53 [Qemu-devel] [PATCH] configure: check for pixman-1 version Hu Tao
2014-09-15 2:23 ` Peter Maydell [this message]
2014-09-15 2:41 ` Hu Tao
2014-09-15 3:19 ` Hu Tao
2014-09-15 12:22 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_dNUJb1L8sYrNv0e4U8gNaq_tNrGLkFG1gWAP2j-XWpA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=hutao@cn.fujitsu.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).