From: Peter Maydell <peter.maydell@linaro.org>
To: Corey Minyard <minyard@acm.org>
Cc: Alastair D'Silva <alastair@au1.ibm.com>,
Fabio Urquiza <flus@cesar.org.br>,
QEMU Developers <qemu-devel@nongnu.org>,
Corey Minyard <cminyard@mvista.com>
Subject: Re: [Qemu-devel] [PATCH] i2c: Allow I2C devices to NAK start events
Date: Thu, 5 Jan 2017 15:42:35 +0000 [thread overview]
Message-ID: <CAFEAcA_dYWidb9Td=1Of76pK+jieYxCSSze3o5GCFgfzcyZg6Q@mail.gmail.com> (raw)
In-Reply-To: <1482269164-14642-1-git-send-email-minyard@acm.org>
On 20 December 2016 at 21:26, <minyard@acm.org> wrote:
> From: Corey Minyard <cminyard@mvista.com>
>
> Add a return value to the event handler. Some I2C devices will
> NAK if they have no data, so allow them to do this. This required
> the following changes:
>
> Go through all the event handlers and change them to return int
> and return 0.
>
> Modify i2c_start_transfer to terminate the transaction on a NAK.
>
> Modify smbus handing to not assert if a NAK occurs on a second
> operation, and terminate the transaction and return -1 instead.
>
> Add some information on semantics to I2CSlaveClass.
>
> Signed-off-by: Corey Minyard <cminyard@mvista.com>
Thanks; added to target-arm.next.
-- PMM
prev parent reply other threads:[~2017-01-05 15:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 19:46 [Qemu-devel] [PATCH 0/2] Add Atmel I2C TPM AT97SC3204T emulated device Fabio Urquiza
2016-11-23 19:46 ` [Qemu-devel] [PATCH 1/2] i2c: Add flag to NACK I2C transfers when busy Fabio Urquiza
2016-11-23 19:46 ` [Qemu-devel] [PATCH 2/2] tpm: Add TPM I2C Atmel frontend Fabio Urquiza
2016-11-29 13:30 ` [Qemu-devel] [PATCH 0/2] Add Atmel I2C TPM AT97SC3204T emulated device no-reply
2016-11-29 19:30 ` [Qemu-devel] [PATCH v1 " Fabio Urquiza
2016-11-29 19:30 ` [Qemu-devel] [PATCH v1 1/2] i2c: Add flag to NACK I2C transfers when busy Fabio Urquiza
2016-11-29 19:30 ` [Qemu-devel] [PATCH v1 2/2] tpm: Add TPM I2C Atmel frontend Fabio Urquiza
2016-12-16 17:35 ` [Qemu-devel] [PATCH v1 0/2] Add Atmel I2C TPM AT97SC3204T emulated device Peter Maydell
2016-12-19 1:47 ` Alastair D'Silva
2016-12-19 13:55 ` Corey Minyard
2016-12-19 15:31 ` Peter Maydell
2016-12-19 16:20 ` Corey Minyard
2016-12-20 21:26 ` [Qemu-devel] [PATCH] i2c: Allow I2C devices to NAK start events minyard
2017-01-05 15:42 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA_dYWidb9Td=1Of76pK+jieYxCSSze3o5GCFgfzcyZg6Q@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=alastair@au1.ibm.com \
--cc=cminyard@mvista.com \
--cc=flus@cesar.org.br \
--cc=minyard@acm.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).