From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DECB8C76188 for ; Mon, 22 Jul 2019 12:40:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A9551218A0 for ; Mon, 22 Jul 2019 12:40:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rliV6h3d" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A9551218A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33184 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpXcY-0007eN-Pr for qemu-devel@archiver.kernel.org; Mon, 22 Jul 2019 08:40:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38843) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpXcM-0007G3-Fc for qemu-devel@nongnu.org; Mon, 22 Jul 2019 08:40:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hpXcL-0008D6-KS for qemu-devel@nongnu.org; Mon, 22 Jul 2019 08:40:38 -0400 Received: from mail-ot1-x341.google.com ([2607:f8b0:4864:20::341]:37444) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hpXcL-0008CN-9z for qemu-devel@nongnu.org; Mon, 22 Jul 2019 08:40:37 -0400 Received: by mail-ot1-x341.google.com with SMTP id s20so40009313otp.4 for ; Mon, 22 Jul 2019 05:40:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HsTdmCxgXi+6pijpOM2b0mxeR19GyIVc32F3yPha3LQ=; b=rliV6h3d7Ul9cIlXJrwaCTtQNDxRg6R6p4BnbqdTLIEXPielXIou0a10WyCl6jW4j4 zgDOlIp90Pe0DWIyPnO7SHyBDS+j+P/CvehdKWV/WTWERuBi6zdSQrupxV1G2nOAt7ms qEKo4DAQKrI+/a/GoW0DpjCalRbq2MRSU+f1R/EAUk+JLgRJmcgnCxjHaiAI98b6p6CH BqAmBoi0WO9eTTAuTLseayPU5XU3S/dwhZcArYW/dIxqwrTr/7Gk7u6KH1PQ4TUTcn5X +4hCs9zbdHDu8vAXNEHFWqQUqaMl4Hj8sDipRs1+lfD6CuPsiev/qRcX/9PWjBP8TiTS WmTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HsTdmCxgXi+6pijpOM2b0mxeR19GyIVc32F3yPha3LQ=; b=cCB2SIIQT+fYKOliMHRCFOFtRfz73yl4m8JO2uXcN7pX42+w2TOQ3Lq7xKHtlfA2XM ENA0Qvrzk9Kzwufqte+DC7Ihof+65Rh0Omo4tkX6b92o8sy69iwWWxrzNIVmruafpsIs qwpCrPxceyGVZ10tDffNbI5SxJz5MpZlgsjsjGCp6FFeGTR1QWSUReK/xysU4kaFJN43 KxOWKnaSxhGVsCOuek4z5lflHDojQzUb7Vl8MAXNNUvgXlOhZ1zNqVQiIKcUmehr80D2 H2mgMeuu0eAcW7eertsTe/RMFtiY69I7JbVrLRAcHOgUAVO7pbZXRSg28EGYTbZMpzgw 0vOg== X-Gm-Message-State: APjAAAW0eL+l9TbS9cnm/WQr0huPtBHPEr2tU6Yg6ifmpjKcqZv4dCIC NOvHTH77Rst5fQYRRhU8noNRQoK+kB72Cw/9Ye6kFw== X-Google-Smtp-Source: APXvYqzv2CoTab7T3++BeXH5E6uy3tZVdfVqM8g7ax6QORRqHbbDP86nYyr+8mYKe+cz5YcwExs3uv9fKvLcATlFTbQ= X-Received: by 2002:a9d:5f1a:: with SMTP id f26mr15464455oti.91.1563799236755; Mon, 22 Jul 2019 05:40:36 -0700 (PDT) MIME-Version: 1.0 References: <20190719082647.18113-1-mrolnik@gmail.com> <20190719082647.18113-9-mrolnik@gmail.com> <0a74e963-8465-e45e-b5af-6c543c2c7454@redhat.com> In-Reply-To: From: Peter Maydell Date: Mon, 22 Jul 2019 13:40:26 +0100 Message-ID: To: Michael Rolnik Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::341 Subject: Re: [Qemu-devel] [PATCH v27 8/8] target/avr: Add tests X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Thomas Huth , Richard Henderson , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 22 Jul 2019 at 13:33, Michael Rolnik wrote: > I changed it to info_report. > raw binaries are totally fine, however if a user supplies a damaged elf he > will never know if no warning/info is reported. I find a good rule of thumb for architecture specific/board specific code is that if other boards/architectures don't do a particular thing, it's usually better to be consistent with the rest of QEMU, rather than introducing an innovation. "Try to load as an ELF file; if that didn't work fall back to loading as a raw image" is what other parts of QEMU do, and they don't complain about doing it. Otherwise, every user of raw images gets a spurious complaint that their raw image isn't an ELF file... thanks -- PMM