[Qemu-devel] [PATCH] target-arm: Provide model numbers for Sharp PDAs

[Qemu-devel] [PATCH] target-arm: Provide model numbers for Sharp PDAs

[Ryo ONODERA]

qemu-system-arm -M ? provides code names for Sharp Zaurus PDAs.
The code names are difficult to identify what model is emulated.
Please add model numbers to the output of qemu-system-arm -M ?.

Ryo ONODERA (1):
  target-arm: Provide model numbers for Sharp PDAs

 hw/arm/collie.c | 2 +-
 hw/arm/spitz.c  | 8 ++++----
 hw/arm/tosa.c   | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)

-- 
2.6.1

[Qemu-devel] [PATCH] target-arm: Provide model numbers for Sharp PDAs

[Ryo ONODERA]

* For Collie, Akita, Spitz, Borzoi, Terrier and Tosa PDAs, provide
  model numbers and manufacturer (Sharp) information.

Signed-off-by: Ryo ONODERA <ryo_on@yk.rim.or.jp>
---
 hw/arm/collie.c | 2 +-
 hw/arm/spitz.c  | 8 ++++----
 hw/arm/tosa.c   | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/hw/arm/collie.c b/hw/arm/collie.c
index 4e6541e..9991c0c 100644
--- a/hw/arm/collie.c
+++ b/hw/arm/collie.c
@@ -60,7 +60,7 @@ static void collie_init(MachineState *machine)
 
 static void collie_machine_init(MachineClass *mc)
 {
-    mc->desc = "Collie PDA (SA-1110)";
+    mc->desc = "Sharp SL-5500 (Collie) PDA (SA-1110)";
     mc->init = collie_init;
 }
 
diff --git a/hw/arm/spitz.c b/hw/arm/spitz.c
index 2af03be..8d3cc0b 100644
--- a/hw/arm/spitz.c
+++ b/hw/arm/spitz.c
@@ -976,7 +976,7 @@ static void akitapda_class_init(ObjectClass *oc, void *data)
 {
     MachineClass *mc = MACHINE_CLASS(oc);
 
-    mc->desc = "Akita PDA (PXA270)";
+    mc->desc = "Sharp SL-C1000 (Akita) PDA (PXA270)";
     mc->init = akita_init;
 }
 
@@ -990,7 +990,7 @@ static void spitzpda_class_init(ObjectClass *oc, void *data)
 {
     MachineClass *mc = MACHINE_CLASS(oc);
 
-    mc->desc = "Spitz PDA (PXA270)";
+    mc->desc = "Sharp SL-C3000 (Spitz) PDA (PXA270)";
     mc->init = spitz_init;
 }
 
@@ -1004,7 +1004,7 @@ static void borzoipda_class_init(ObjectClass *oc, void *data)
 {
     MachineClass *mc = MACHINE_CLASS(oc);
 
-    mc->desc = "Borzoi PDA (PXA270)";
+    mc->desc = "Sharp SL-C3100 (Borzoi) PDA (PXA270)";
     mc->init = borzoi_init;
 }
 
@@ -1018,7 +1018,7 @@ static void terrierpda_class_init(ObjectClass *oc, void *data)
 {
     MachineClass *mc = MACHINE_CLASS(oc);
 
-    mc->desc = "Terrier PDA (PXA270)";
+    mc->desc = "Sharp SL-C3200 (Terrier) PDA (PXA270)";
     mc->init = terrier_init;
 }
 
diff --git a/hw/arm/tosa.c b/hw/arm/tosa.c
index 51d0b89..02814d7 100644
--- a/hw/arm/tosa.c
+++ b/hw/arm/tosa.c
@@ -254,7 +254,7 @@ static void tosa_init(MachineState *machine)
 
 static void tosapda_machine_init(MachineClass *mc)
 {
-    mc->desc = "Tosa PDA (PXA255)";
+    mc->desc = "Sharp SL-6000 (Tosa) PDA (PXA255)";
     mc->init = tosa_init;
 }
 
-- 
2.6.1

Re: [Qemu-devel] [PATCH] target-arm: Provide model numbers for Sharp PDAs

[Peter Maydell]

On 12 October 2015 at 12:36, Ryo ONODERA <ryo_on@yk.rim.or.jp> wrote:
> qemu-system-arm -M ? provides code names for Sharp Zaurus PDAs.
> The code names are difficult to identify what model is emulated.
> Please add model numbers to the output of qemu-system-arm -M ?.
>
> Ryo ONODERA (1):
>   target-arm: Provide model numbers for Sharp PDAs
>
>  hw/arm/collie.c | 2 +-
>  hw/arm/spitz.c  | 8 ++++----
>  hw/arm/tosa.c   | 2 +-
>  3 files changed, 6 insertions(+), 6 deletions(-)

Thanks for this patch; I have applied it to my target-arm.next
branch.

-- PMM

Re: [Qemu-devel] [PATCH] target-arm: Provide model numbers for Sharp PDAs

[Ryo ONODERA]

Dear Peter Maydell,

From: Peter Maydell <peter.maydell@linaro.org>, Date: Tue, 13 Oct 2015 18:17:57 +0100

> On 12 October 2015 at 12:36, Ryo ONODERA <ryo_on@yk.rim.or.jp> wrote:
>> qemu-system-arm -M ? provides code names for Sharp Zaurus PDAs.
>> The code names are difficult to identify what model is emulated.
>> Please add model numbers to the output of qemu-system-arm -M ?.
>>
>> Ryo ONODERA (1):
>>   target-arm: Provide model numbers for Sharp PDAs
>>
>>  hw/arm/collie.c | 2 +-
>>  hw/arm/spitz.c  | 8 ++++----
>>  hw/arm/tosa.c   | 2 +-
>>  3 files changed, 6 insertions(+), 6 deletions(-)
> 
> Thanks for this patch; I have applied it to my target-arm.next
> branch.

Thank you very much for your quick response.

> -- PMM

Best Regards,

--
Ryo ONODERA // ryo_on@yk.rim.or.jp
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3