From: Peter Maydell <peter.maydell@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: "Manos Pitsidianakis" <manos.pitsidianakis@linaro.org>,
"Daniel P. Berrangé" <berrange@redhat.com>,
qemu-devel@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: Re: [PATCH v2] scripts/checkpatch.pl: check for placeholders in cover letter patches
Date: Tue, 30 Jan 2024 15:22:05 +0000 [thread overview]
Message-ID: <CAFEAcA_eMbsyt8rogW2VNqGEqbe0EXPhyf9uv4CdKZZp6ED6-Q@mail.gmail.com> (raw)
In-Reply-To: <875xzaonzv.fsf@draig.linaro.org>
On Tue, 30 Jan 2024 at 15:11, Alex Bennée <alex.bennee@linaro.org> wrote:
> I suspect the problem is that checkpatch.pl is an import from the Linux
> source tree which has since had syncs with its upstream as well as a
> slew of QEMU specific patches. If we don't care about tracking upstream
> anymore we could bite the bullet and fix indentation going forward.
I had a look at trying to update to be based on a newer
version of the Linux checkpatch some years ago, but it turned
out to not be a trivial thing to do, and we've only diverged
further since then. (Which is unfortunate, because I imagine
there have been bugfixes to the perl script's handling of
parsing fragments of C code which we'd like.)
-- PMM
next prev parent reply other threads:[~2024-01-30 15:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 10:11 [PATCH v2] scripts/checkpatch.pl: check for placeholders in cover letter patches Manos Pitsidianakis
2024-01-30 10:15 ` Daniel P. Berrangé
2024-01-30 10:26 ` Manos Pitsidianakis
2024-01-30 15:11 ` Alex Bennée
2024-01-30 15:22 ` Peter Maydell [this message]
2024-01-30 19:09 ` Philippe Mathieu-Daudé
2024-01-30 10:34 ` Peter Maydell
2024-01-30 10:39 ` Manos Pitsidianakis
2024-01-30 10:42 ` Peter Maydell
2024-01-30 10:51 ` Manos Pitsidianakis
2024-01-30 10:57 ` Peter Maydell
2024-01-30 11:02 ` Manos Pitsidianakis
2024-01-30 11:24 ` Philippe Mathieu-Daudé
2024-01-30 11:30 ` Peter Maydell
2024-01-30 11:57 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_eMbsyt8rogW2VNqGEqbe0EXPhyf9uv4CdKZZp6ED6-Q@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=manos.pitsidianakis@linaro.org \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).