From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59000) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0shG-0001fv-HQ for qemu-devel@nongnu.org; Tue, 16 Dec 2014 09:02:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0shB-00082m-FW for qemu-devel@nongnu.org; Tue, 16 Dec 2014 09:01:54 -0500 Received: from mail-lb0-f171.google.com ([209.85.217.171]:34306) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0shB-00082P-8I for qemu-devel@nongnu.org; Tue, 16 Dec 2014 09:01:49 -0500 Received: by mail-lb0-f171.google.com with SMTP id w7so6631237lbi.2 for ; Tue, 16 Dec 2014 06:01:48 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1418721773-29042-1-git-send-email-arei.gonglei@huawei.com> References: <1418721773-29042-1-git-send-email-arei.gonglei@huawei.com> From: Peter Maydell Date: Tue, 16 Dec 2014 14:01:28 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PULL 0/5] bootdevice patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gonglei (Arei)" Cc: QEMU Developers On 16 December 2014 at 09:22, wrote: > From: root > > This is my first pull request as a submaintainer. Those patches just > move boot order related code to bootdevice.c and add a Error **errp > argument for corresponding functions so that it can propagate error messages > to the caller. Please pull. This also seems to cause 'make check' to fail: TEST: tests/boot-order-test... (pid=16958) /i386/boot-order/pc: Broken pipe FAIL GTester: last random seed: R02S5702c094d31af53e45fffabed844705a (pid=16973) FAIL: tests/boot-order-test thanks -- PMM