From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60847) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aK5Fs-0000wJ-2X for qemu-devel@nongnu.org; Fri, 15 Jan 2016 09:21:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aK5Fr-00006d-4X for qemu-devel@nongnu.org; Fri, 15 Jan 2016 09:21:32 -0500 Received: from mail-vk0-x234.google.com ([2607:f8b0:400c:c05::234]:36571) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aK5Fq-00006T-Uq for qemu-devel@nongnu.org; Fri, 15 Jan 2016 09:21:31 -0500 Received: by mail-vk0-x234.google.com with SMTP id n1so144531640vkb.3 for ; Fri, 15 Jan 2016 06:21:30 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1452700993-6570-1-git-send-email-aurelien@aurel32.net> References: <1452700993-6570-1-git-send-email-aurelien@aurel32.net> From: Peter Maydell Date: Fri, 15 Jan 2016 14:21:11 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH RESEND] softfloat: fix return type of roundAndPackFloat16 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: QEMU Developers On 13 January 2016 at 16:03, Aurelien Jarno wrote: > The roundAndPackFloat16 function should return a float16 value, not a > float32 one. Fix that. > > Cc: Peter Maydell > Signed-off-by: Aurelien Jarno > --- > fpu/softfloat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Peter, given you are working on softfloat patches, you might want to get > this one merged at the same time. > > diff --git a/fpu/softfloat.c b/fpu/softfloat.c > index f1170fe..acc9099 100644 > --- a/fpu/softfloat.c > +++ b/fpu/softfloat.c > @@ -3368,7 +3368,7 @@ static float16 packFloat16(flag zSign, int_fast16_t zExp, uint16_t zSig) > | Binary Floating-Point Arithmetic. > *----------------------------------------------------------------------------*/ > > -static float32 roundAndPackFloat16(flag zSign, int_fast16_t zExp, > +static float16 roundAndPackFloat16(flag zSign, int_fast16_t zExp, > uint32_t zSig, flag ieee, > float_status *status) > { Reviewed-by: Peter Maydell (a harmless error in the current code but we might as well get it right). thanks -- PMM