From: Peter Maydell <peter.maydell@linaro.org>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-stable <qemu-stable@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Christopher Covington <cov@codeaurora.org>
Subject: Re: [Qemu-devel] [PATCH] hw/arm/boot: Set PC correctly when loading AArch64 ELF files
Date: Tue, 29 Jul 2014 20:31:29 +0100 [thread overview]
Message-ID: <CAFEAcA_ey_yiighJovKp_HEry9UMG29=FFDeU1ua2kd_r1vUPg@mail.gmail.com> (raw)
In-Reply-To: <53D7F518.4020603@twiddle.net>
On 29 July 2014 20:25, Richard Henderson <rth@twiddle.net> wrote:
> On 07/25/2014 05:23 AM, Peter Maydell wrote:
>> + env->regs[15] = info->entry & 0xfffffffe;
>
> You'd do well to use a U suffix here, otherwise c89 makes this -2 while c99
> does what you want. Which makes a tiny difference on a 64-bit host.
Given that env->regs[] is uint32_t, does it actually change the final
result? I agree that a U suffix would be a good idea, but given that
the code has been that way since 2009 it seems unlikely that we've
actually got breakage from it...
thanks
-- PMM
next prev parent reply other threads:[~2014-07-29 19:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 15:23 [Qemu-devel] [PATCH] hw/arm/boot: Set PC correctly when loading AArch64 ELF files Peter Maydell
2014-07-25 16:09 ` Christopher Covington
2014-07-29 19:25 ` Richard Henderson
2014-07-29 19:31 ` Peter Maydell [this message]
2014-07-29 19:57 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA_ey_yiighJovKp_HEry9UMG29=FFDeU1ua2kd_r1vUPg@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=cov@codeaurora.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).