From: Peter Maydell <peter.maydell@linaro.org>
To: Amit Shah <amit.shah@redhat.com>
Cc: marcandre.lureau@redhat.com, Amos Kong <akong@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
qemu list <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2 1/1] virtio: serial: expose a 'guest_writable' callback for users
Date: Fri, 10 Oct 2014 12:23:21 +0100 [thread overview]
Message-ID: <CAFEAcA_f_y4bOn83tkpm4ekb87exFHq4P341Vb4u9QAXr6A3hg@mail.gmail.com> (raw)
In-Reply-To: <20141010111918.GE16326@grmbl.mre>
On 10 October 2014 12:19, Amit Shah <amit.shah@redhat.com> wrote:
> On (Thu) 09 Oct 2014 [14:04:53], Peter Maydell wrote:
>> What I would like to see in this patch is a comment giving
>> much clearer definition of the semantics of the guest_writable
>> call: for instance, is it always called when the guest is
>> writable, or is it only guaranteed to be called if the
>> QEMU backend has previously tried to do virtio_serial_write
>> and got back a return code indicating an incomplete write?
>
> Right now it's called always; if it's necessary to only call after an
> incomplete / failed write, we just need to implement that (and also
> add that state to the migration data).
>
> I have no preference; just depends on the users of the API.
Called-always makes sense; I'd just like to see the semantics
documented so you don't have to read the whole implementation
of virtio to figure out what they are :-)
-- PMM
next prev parent reply other threads:[~2014-10-10 11:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 16:13 [Qemu-devel] [PATCH v2 1/1] virtio: serial: expose a 'guest_writable' callback for users Amit Shah
2014-10-09 11:18 ` Markus Armbruster
2014-10-09 12:17 ` Amit Shah
2014-10-09 13:04 ` Peter Maydell
2014-10-10 11:19 ` Amit Shah
2014-10-10 11:23 ` Peter Maydell [this message]
2014-10-10 12:07 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_f_y4bOn83tkpm4ekb87exFHq4P341Vb4u9QAXr6A3hg@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=akong@redhat.com \
--cc=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).