From: Peter Maydell <peter.maydell@linaro.org>
To: Laurent Vivier <laurent@vivier.eu>
Cc: "Kamil Rytarowski" <n54@gmx.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const static array to switch
Date: Mon, 4 Sep 2017 17:40:02 +0100 [thread overview]
Message-ID: <CAFEAcA_gAq4Gi7DZiPunTt1xwB8UpGSdw9uZqTTu602f99WEcw@mail.gmail.com> (raw)
In-Reply-To: <ef498496-0009-0483-841c-7d6a793365bf@vivier.eu>
On 4 September 2017 at 17:38, Laurent Vivier <laurent@vivier.eu> wrote:
> Le 04/09/2017 à 18:38, Kamil Rytarowski a écrit :
>> I will push my patch as is and later it can be refactored by a
>> maintainer. Is this fine?
>>
>> https://github.com/NetBSD/pkgsrc-wip/blob/master/qemu-git/patches/patch-target_m68k_fpu__helper.c
>>
>
> If Peter agrees, the patch is good for me as is: I never liked the mix
> of macros and values in this array. Send it to the list, I will put it
> in my next pull request.
OK, if you're happy with it I'm happy with it.
thanks
-- PMM
next prev parent reply other threads:[~2017-09-04 16:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-03 16:31 [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const static array to switch Kamil Rytarowski
2017-09-03 17:05 ` Laurent Vivier
2017-09-04 0:27 ` Philippe Mathieu-Daudé
2017-09-04 13:54 ` Kamil Rytarowski
2017-09-04 14:09 ` Laurent Vivier
2017-09-04 14:41 ` Philippe Mathieu-Daudé
2017-09-04 14:53 ` Kamil Rytarowski
2017-09-04 15:02 ` Peter Maydell
2017-09-04 15:16 ` Kamil Rytarowski
2017-09-04 15:53 ` Laurent Vivier
2017-09-04 16:17 ` Peter Maydell
2017-09-04 16:38 ` Kamil Rytarowski
2017-09-04 16:38 ` Laurent Vivier
2017-09-04 16:40 ` Peter Maydell [this message]
2017-09-04 8:00 ` no-reply
2017-09-04 16:46 ` [Qemu-devel] [PATCH v2] target/m68k: Switch fpu_rom from make_floatx80() to make_floatx80_init() Kamil Rytarowski
2017-09-04 17:16 ` Philippe Mathieu-Daudé
2017-09-04 17:23 ` Laurent Vivier
2017-09-04 18:01 ` Philippe Mathieu-Daudé
2017-09-04 17:32 ` [Qemu-devel] [PATCH v3] " Kamil Rytarowski
2017-09-04 19:02 ` Laurent Vivier
2017-09-04 21:38 ` Kamil Rytarowski
2017-09-04 21:23 ` [Qemu-devel] [PATCH v4] " Kamil Rytarowski
2017-09-04 21:44 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_gAq4Gi7DZiPunTt1xwB8UpGSdw9uZqTTu602f99WEcw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=f4bug@amsat.org \
--cc=laurent@vivier.eu \
--cc=n54@gmx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).