From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58238) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1douQG-0007Be-JU for qemu-devel@nongnu.org; Mon, 04 Sep 2017 12:40:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1douQB-0004qK-Tw for qemu-devel@nongnu.org; Mon, 04 Sep 2017 12:40:28 -0400 Received: from mail-wr0-x230.google.com ([2a00:1450:400c:c0c::230]:33406) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1douQB-0004po-NS for qemu-devel@nongnu.org; Mon, 04 Sep 2017 12:40:23 -0400 Received: by mail-wr0-x230.google.com with SMTP id a43so3057478wrc.0 for ; Mon, 04 Sep 2017 09:40:23 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20170903163130.14288-1-n54@gmx.com> <9f33a768-77d1-191b-8be3-35d625752cbf@vivier.eu> <1257d6ba-9ca1-0940-af9e-a9ea7dea0287@amsat.org> <941d403b-7413-517f-23af-2c0c88a3ec57@gmx.com> From: Peter Maydell Date: Mon, 4 Sep 2017 17:40:02 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const static array to switch List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier Cc: Kamil Rytarowski , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , QEMU Developers On 4 September 2017 at 17:38, Laurent Vivier wrote: > Le 04/09/2017 =C3=A0 18:38, Kamil Rytarowski a =C3=A9crit : >> I will push my patch as is and later it can be refactored by a >> maintainer. Is this fine? >> >> https://github.com/NetBSD/pkgsrc-wip/blob/master/qemu-git/patches/patch-= target_m68k_fpu__helper.c >> > > If Peter agrees, the patch is good for me as is: I never liked the mix > of macros and values in this array. Send it to the list, I will put it > in my next pull request. OK, if you're happy with it I'm happy with it. thanks -- PMM