* [PATCH 0/1] versal-ospi fix
@ 2023-12-05 10:08 Sai Pavan Boddu
2023-12-05 10:08 ` [PATCH 1/1] xlnx-versal-ospi: disable reentrancy detection for iomem_dac Sai Pavan Boddu
0 siblings, 1 reply; 6+ messages in thread
From: Sai Pavan Boddu @ 2023-12-05 10:08 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-arm, qemu-block, Alistair Francis, Edgar E. Iglesias,
Peter Maydell, Kevin Wolf, Francisco Iglesias, saipavanboddu
Disable reentrancy on iomem_dac memory-region.
Sai Pavan Boddu (1):
xlnx-versal-ospi: disable reentrancy detection for iomem_dac
hw/ssi/xlnx-versal-ospi.c | 1 +
1 file changed, 1 insertion(+)
--
2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] xlnx-versal-ospi: disable reentrancy detection for iomem_dac
2023-12-05 10:08 [PATCH 0/1] versal-ospi fix Sai Pavan Boddu
@ 2023-12-05 10:08 ` Sai Pavan Boddu
2023-12-12 16:42 ` Peter Maydell
0 siblings, 1 reply; 6+ messages in thread
From: Sai Pavan Boddu @ 2023-12-05 10:08 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-arm, qemu-block, Alistair Francis, Edgar E. Iglesias,
Peter Maydell, Kevin Wolf, Francisco Iglesias, saipavanboddu
The OSPI DMA reads flash data through the OSPI linear address space (the
iomem_dac region), because of this the reentrancy guard introduced in
commit a2e1753b ("memory: prevent dma-reentracy issues") is disabled for
the memory region.
Signed-off-by: Sai Pavan Boddu <sai.pavan.boddu@amd.com>
---
hw/ssi/xlnx-versal-ospi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ssi/xlnx-versal-ospi.c b/hw/ssi/xlnx-versal-ospi.c
index 1a61679c2f..5123e7dde7 100644
--- a/hw/ssi/xlnx-versal-ospi.c
+++ b/hw/ssi/xlnx-versal-ospi.c
@@ -1772,6 +1772,7 @@ static void xlnx_versal_ospi_init(Object *obj)
memory_region_init_io(&s->iomem_dac, obj, &ospi_dac_ops, s,
TYPE_XILINX_VERSAL_OSPI "-dac", 0x20000000);
sysbus_init_mmio(sbd, &s->iomem_dac);
+ s->iomem_dac.disable_reentrancy_guard = true;
sysbus_init_irq(sbd, &s->irq);
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] xlnx-versal-ospi: disable reentrancy detection for iomem_dac
2023-12-05 10:08 ` [PATCH 1/1] xlnx-versal-ospi: disable reentrancy detection for iomem_dac Sai Pavan Boddu
@ 2023-12-12 16:42 ` Peter Maydell
2023-12-14 5:34 ` Boddu, Sai Pavan
0 siblings, 1 reply; 6+ messages in thread
From: Peter Maydell @ 2023-12-12 16:42 UTC (permalink / raw)
To: Sai Pavan Boddu
Cc: qemu-devel, qemu-arm, qemu-block, Alistair Francis,
Edgar E. Iglesias, Kevin Wolf, Francisco Iglesias, saipavanboddu
On Tue, 5 Dec 2023 at 10:08, Sai Pavan Boddu <sai.pavan.boddu@amd.com> wrote:
>
> The OSPI DMA reads flash data through the OSPI linear address space (the
> iomem_dac region), because of this the reentrancy guard introduced in
> commit a2e1753b ("memory: prevent dma-reentracy issues") is disabled for
> the memory region.
>
> Signed-off-by: Sai Pavan Boddu <sai.pavan.boddu@amd.com>
> ---
> hw/ssi/xlnx-versal-ospi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/ssi/xlnx-versal-ospi.c b/hw/ssi/xlnx-versal-ospi.c
> index 1a61679c2f..5123e7dde7 100644
> --- a/hw/ssi/xlnx-versal-ospi.c
> +++ b/hw/ssi/xlnx-versal-ospi.c
> @@ -1772,6 +1772,7 @@ static void xlnx_versal_ospi_init(Object *obj)
> memory_region_init_io(&s->iomem_dac, obj, &ospi_dac_ops, s,
> TYPE_XILINX_VERSAL_OSPI "-dac", 0x20000000);
> sysbus_init_mmio(sbd, &s->iomem_dac);
> + s->iomem_dac.disable_reentrancy_guard = true;
Where we set this flag we should have a comment explaining why
we need to do it, please.
PS: for a single patch you don't need to use a separate cover letter;
cover letters are only needed for multi-patch series.
thanks
-- PMM
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH 1/1] xlnx-versal-ospi: disable reentrancy detection for iomem_dac
2023-12-12 16:42 ` Peter Maydell
@ 2023-12-14 5:34 ` Boddu, Sai Pavan
0 siblings, 0 replies; 6+ messages in thread
From: Boddu, Sai Pavan @ 2023-12-14 5:34 UTC (permalink / raw)
To: Peter Maydell
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, qemu-block@nongnu.org,
Alistair Francis, Edgar E. Iglesias, Kevin Wolf,
Francisco Iglesias, saipavanboddu@gmail.com
Hi Peter,
>-----Original Message-----
>From: Peter Maydell <peter.maydell@linaro.org>
>Sent: Tuesday, December 12, 2023 10:12 PM
>To: Boddu, Sai Pavan <sai.pavan.boddu@amd.com>
>Cc: qemu-devel@nongnu.org; qemu-arm@nongnu.org; qemu-
>block@nongnu.org; Alistair Francis <alistair@alistair23.me>; Edgar E. Iglesias
><edgar.iglesias@gmail.com>; Kevin Wolf <kwolf@redhat.com>; Francisco
>Iglesias <frasse.iglesias@gmail.com>; saipavanboddu@gmail.com
>Subject: Re: [PATCH 1/1] xlnx-versal-ospi: disable reentrancy detection for
>iomem_dac
>
>On Tue, 5 Dec 2023 at 10:08, Sai Pavan Boddu <sai.pavan.boddu@amd.com>
>wrote:
>>
>> The OSPI DMA reads flash data through the OSPI linear address space
>> (the iomem_dac region), because of this the reentrancy guard
>> introduced in commit a2e1753b ("memory: prevent dma-reentracy issues")
>> is disabled for the memory region.
>>
>> Signed-off-by: Sai Pavan Boddu <sai.pavan.boddu@amd.com>
>> ---
>> hw/ssi/xlnx-versal-ospi.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/ssi/xlnx-versal-ospi.c b/hw/ssi/xlnx-versal-ospi.c
>> index 1a61679c2f..5123e7dde7 100644
>> --- a/hw/ssi/xlnx-versal-ospi.c
>> +++ b/hw/ssi/xlnx-versal-ospi.c
>> @@ -1772,6 +1772,7 @@ static void xlnx_versal_ospi_init(Object *obj)
>> memory_region_init_io(&s->iomem_dac, obj, &ospi_dac_ops, s,
>> TYPE_XILINX_VERSAL_OSPI "-dac", 0x20000000);
>> sysbus_init_mmio(sbd, &s->iomem_dac);
>> + s->iomem_dac.disable_reentrancy_guard = true;
>
>Where we set this flag we should have a comment explaining why we need to
>do it, please.
[Boddu, Sai Pavan] Sure, I will send a V2 on this.
Regards,
Sai pavan
>
>PS: for a single patch you don't need to use a separate cover letter; cover letters
>are only needed for multi-patch series.
>
>thanks
>-- PMM
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 0/1] versal-ospi fix
@ 2023-12-05 9:48 Sai Pavan Boddu
2023-12-05 9:48 ` [PATCH 1/1] xlnx-versal-ospi: disable reentrancy detection for iomem_dac Sai Pavan Boddu
0 siblings, 1 reply; 6+ messages in thread
From: Sai Pavan Boddu @ 2023-12-05 9:48 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-arm, qemu-block, Alistair Francis, Edgar E. Iglesias,
Peter Maydell, Kevin Wolf, Francisco Iglesias, saipavanboddu
Disable reentrancy on iomem_dac memory-region.
Sai Pavan Boddu (1):
xlnx-versal-ospi: disable reentrancy detection for iomem_dac
hw/ssi/xlnx-versal-ospi.c | 1 +
1 file changed, 1 insertion(+)
--
2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] xlnx-versal-ospi: disable reentrancy detection for iomem_dac
2023-12-05 9:48 [PATCH 0/1] versal-ospi fix Sai Pavan Boddu
@ 2023-12-05 9:48 ` Sai Pavan Boddu
2023-12-05 19:58 ` Francisco Iglesias
0 siblings, 1 reply; 6+ messages in thread
From: Sai Pavan Boddu @ 2023-12-05 9:48 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-arm, qemu-block, Alistair Francis, Edgar E. Iglesias,
Peter Maydell, Kevin Wolf, Francisco Iglesias, saipavanboddu
The OSPI DMA reads flash data through the OSPI linear address space (the
iomem_dac region), because of this the reentrancy guard introduced in
commit a2e1753b ("memory: prevent dma-reentracy issues") is disabled for
the memory region.
Signed-off-by: Sai Pavan Boddu <sai.pavan.boddu@amd.com>
---
hw/ssi/xlnx-versal-ospi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ssi/xlnx-versal-ospi.c b/hw/ssi/xlnx-versal-ospi.c
index 1a61679c2f..5123e7dde7 100644
--- a/hw/ssi/xlnx-versal-ospi.c
+++ b/hw/ssi/xlnx-versal-ospi.c
@@ -1772,6 +1772,7 @@ static void xlnx_versal_ospi_init(Object *obj)
memory_region_init_io(&s->iomem_dac, obj, &ospi_dac_ops, s,
TYPE_XILINX_VERSAL_OSPI "-dac", 0x20000000);
sysbus_init_mmio(sbd, &s->iomem_dac);
+ s->iomem_dac.disable_reentrancy_guard = true;
sysbus_init_irq(sbd, &s->irq);
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] xlnx-versal-ospi: disable reentrancy detection for iomem_dac
2023-12-05 9:48 ` [PATCH 1/1] xlnx-versal-ospi: disable reentrancy detection for iomem_dac Sai Pavan Boddu
@ 2023-12-05 19:58 ` Francisco Iglesias
0 siblings, 0 replies; 6+ messages in thread
From: Francisco Iglesias @ 2023-12-05 19:58 UTC (permalink / raw)
To: Sai Pavan Boddu
Cc: qemu-devel, qemu-arm, qemu-block, Alistair Francis,
Edgar E. Iglesias, Peter Maydell, Kevin Wolf, saipavanboddu
On [2023 Dec 05] Tue 15:18:02, Sai Pavan Boddu wrote:
> The OSPI DMA reads flash data through the OSPI linear address space (the
> iomem_dac region), because of this the reentrancy guard introduced in
> commit a2e1753b ("memory: prevent dma-reentracy issues") is disabled for
> the memory region.
>
> Signed-off-by: Sai Pavan Boddu <sai.pavan.boddu@amd.com>
Reviewed-by: Francisco Iglesias <frasse.iglesias@gmail.com>
Tested-by: Francisco Iglesias <frasse.iglesias@gmail.com>
> ---
> hw/ssi/xlnx-versal-ospi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/ssi/xlnx-versal-ospi.c b/hw/ssi/xlnx-versal-ospi.c
> index 1a61679c2f..5123e7dde7 100644
> --- a/hw/ssi/xlnx-versal-ospi.c
> +++ b/hw/ssi/xlnx-versal-ospi.c
> @@ -1772,6 +1772,7 @@ static void xlnx_versal_ospi_init(Object *obj)
> memory_region_init_io(&s->iomem_dac, obj, &ospi_dac_ops, s,
> TYPE_XILINX_VERSAL_OSPI "-dac", 0x20000000);
> sysbus_init_mmio(sbd, &s->iomem_dac);
> + s->iomem_dac.disable_reentrancy_guard = true;
>
> sysbus_init_irq(sbd, &s->irq);
>
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-12-14 5:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-05 10:08 [PATCH 0/1] versal-ospi fix Sai Pavan Boddu
2023-12-05 10:08 ` [PATCH 1/1] xlnx-versal-ospi: disable reentrancy detection for iomem_dac Sai Pavan Boddu
2023-12-12 16:42 ` Peter Maydell
2023-12-14 5:34 ` Boddu, Sai Pavan
-- strict thread matches above, loose matches on Subject: below --
2023-12-05 9:48 [PATCH 0/1] versal-ospi fix Sai Pavan Boddu
2023-12-05 9:48 ` [PATCH 1/1] xlnx-versal-ospi: disable reentrancy detection for iomem_dac Sai Pavan Boddu
2023-12-05 19:58 ` Francisco Iglesias
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).