From: Peter Maydell <peter.maydell@linaro.org>
To: Akihiko Odaki <akihiko.odaki@daynix.com>
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Marek Glogowski" <smarkusg@gmail.com>,
"BALATON Zoltan" <balaton@eik.bme.hu>,
"Rene Engel" <ReneEngel80@emailn.de>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v12 03/10] ui/cocoa: Release specific mouse buttons
Date: Mon, 26 Feb 2024 17:00:51 +0000 [thread overview]
Message-ID: <CAFEAcA_h0cYY45Dwz2aOc6bBc5QErd-Uj42swNXf_MZRwncMsA@mail.gmail.com> (raw)
In-Reply-To: <20240224-cocoa-v12-3-e89f70bdda71@daynix.com>
On Sat, 24 Feb 2024 at 12:43, Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
>
> ui/cocoa used to release all mouse buttons when it sees
> NSEventTypeLeftMouseUp, NSEventTypeRightMouseUp, or
> NSEventTypeOtherMouseUp, but it can instead release specific one
> according to the delivered event.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> ui/cocoa.m | 36 +++++++++++++++---------------------
> 1 file changed, 15 insertions(+), 21 deletions(-)
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
next prev parent reply other threads:[~2024-02-26 17:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-24 12:43 [PATCH v12 00/10] ui/cocoa: Use NSWindow's ability to resize Akihiko Odaki
2024-02-24 12:43 ` [PATCH v12 01/10] ui/cocoa: Split [-QemuCocoaView handleEventLocked:] Akihiko Odaki
2024-02-26 16:58 ` Peter Maydell
2024-02-24 12:43 ` [PATCH v12 02/10] ui/cocoa: Immediately call [-QemuCocoaView handleMouseEvent:buttons:] Akihiko Odaki
2024-02-26 16:59 ` Peter Maydell
2024-02-24 12:43 ` [PATCH v12 03/10] ui/cocoa: Release specific mouse buttons Akihiko Odaki
2024-02-26 17:00 ` Peter Maydell [this message]
2024-02-24 12:43 ` [PATCH v12 04/10] ui/cocoa: Scale with NSView instead of Core Graphics Akihiko Odaki
2024-02-24 12:43 ` [PATCH v12 05/10] ui/cocoa: Fix pause label coordinates Akihiko Odaki
2024-02-26 17:01 ` Peter Maydell
2024-02-24 12:43 ` [PATCH v12 06/10] ui/cocoa: Let the platform toggle fullscreen Akihiko Odaki
2024-02-26 17:14 ` Peter Maydell
2024-02-24 12:43 ` [PATCH v12 07/10] ui/cocoa: Remove normalWindow Akihiko Odaki
2024-02-26 17:04 ` Peter Maydell
2024-02-24 12:43 ` [PATCH v12 08/10] ui/cocoa: Make window resizable Akihiko Odaki
2024-02-24 12:43 ` [PATCH v12 09/10] ui/cocoa: Call console_select() with the BQL Akihiko Odaki
2024-02-24 12:43 ` [PATCH v12 10/10] ui/cocoa: Remove stretch_video flag Akihiko Odaki
2024-02-26 17:02 ` Peter Maydell
2024-02-26 18:19 ` [PATCH v12 00/10] ui/cocoa: Use NSWindow's ability to resize Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_h0cYY45Dwz2aOc6bBc5QErd-Uj42swNXf_MZRwncMsA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=ReneEngel80@emailn.de \
--cc=akihiko.odaki@daynix.com \
--cc=balaton@eik.bme.hu \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=smarkusg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).