From: Peter Maydell <peter.maydell@linaro.org>
To: Ahmed Abouzied <email@aabouzied.com>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
Thomas Huth <thuth@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH] net: Replace TAB indentations with spaces
Date: Mon, 14 Jun 2021 20:06:49 +0100 [thread overview]
Message-ID: <CAFEAcA_h2wQF4nDMhu3WT9AzCEMV3jCkDpuuorTREYaGoKaEwQ@mail.gmail.com> (raw)
In-Reply-To: <20210614183849.20622-1-email@aabouzied.com>
On Mon, 14 Jun 2021 at 19:56, Ahmed Abouzied <email@aabouzied.com> wrote:
>
> Replaces TABs with spaces, making sure to have a consistent coding style
> of 4 space indentations in the net subsystem.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/377
> Signed-off-by: Ahmed Abouzied <email@aabouzied.com>
> ---
> hw/net/can/ctu_can_fd_frame.h | 180 ++---
> hw/net/can/ctu_can_fd_regs.h | 1260 ++++++++++++++++-----------------
> hw/net/e1000_regs.h | 30 +-
> hw/net/mcf_fec.c | 8 +-
> hw/net/ne2000.c | 138 ++--
> hw/net/pcnet.c | 136 ++--
> hw/net/pcnet.h | 4 +-
> net/tap-linux.h | 10 +-
> 8 files changed, 883 insertions(+), 883 deletions(-)
> diff --git a/hw/net/pcnet.c b/hw/net/pcnet.c
> index dcd3fc4948..ba20afefc4 100644
> --- a/hw/net/pcnet.c
> +++ b/hw/net/pcnet.c
> @@ -370,7 +370,7 @@ static inline void pcnet_rmd_load(PCNetState *s, struct pcnet_RMD *rmd,
> uint32_t rbadr;
> int16_t buf_length;
> int16_t msg_length;
> - } rda;
> + } rda;
> s->phys_mem_read(s->dma_opaque, addr, (void *)&rda, sizeof(rda), 0);
> rmd->rbadr = le32_to_cpu(rda.rbadr) & 0xffffff;
> rmd->buf_length = le16_to_cpu(rda.buf_length);
Indent seems to not be right in this hunk ?
thanks
-- PMM
next prev parent reply other threads:[~2021-06-14 19:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 18:38 [PATCH] net: Replace TAB indentations with spaces Ahmed Abouzied
2021-06-14 18:58 ` Philippe Mathieu-Daudé
2021-06-14 19:06 ` Peter Maydell [this message]
2021-06-14 22:45 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_h2wQF4nDMhu3WT9AzCEMV3jCkDpuuorTREYaGoKaEwQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=email@aabouzied.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).