qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Stefan Weil <sw@weilnetz.de>
Cc: Peter Crosthwaite <peter.crosthwaite@petalogix.com>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] xilinx_axienet: Fix bit mask code
Date: Sun, 9 Jun 2013 22:22:09 +0100	[thread overview]
Message-ID: <CAFEAcA_hdTVykTRLEE_3LcyExP0rRaDRgnr3iYNZe_sFR=pjiw@mail.gmail.com> (raw)
In-Reply-To: <1370811380-32554-1-git-send-email-sw@weilnetz.de>

On 9 June 2013 21:56, Stefan Weil <sw@weilnetz.de> wrote:
> diff --git a/hw/net/xilinx_axienet.c b/hw/net/xilinx_axienet.c
> index 8989e95..2ca1511 100644
> --- a/hw/net/xilinx_axienet.c
> +++ b/hw/net/xilinx_axienet.c
> @@ -575,7 +575,7 @@ static void enet_write(void *opaque, hwaddr addr,
>              break;
>
>          case R_MC:
> -             value &= ((1 < 7) - 1);
> +             value &= ((1 << 7) - 1);

Whoops. No objection to this patch as it stands; another option
would be
    value = extract32(value, 0, 7);

thanks
-- PMM

  reply	other threads:[~2013-06-09 21:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-09 20:56 [Qemu-devel] [PATCH] xilinx_axienet: Fix bit mask code Stefan Weil
2013-06-09 21:22 ` Peter Maydell [this message]
2013-06-10 11:05 ` Edgar E. Iglesias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA_hdTVykTRLEE_3LcyExP0rRaDRgnr3iYNZe_sFR=pjiw@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=edgar.iglesias@gmail.com \
    --cc=peter.crosthwaite@petalogix.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).