From: Peter Maydell <peter.maydell@linaro.org>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] vga: print friendly error message in case multiple vga devices are added
Date: Mon, 7 May 2018 14:36:30 +0100 [thread overview]
Message-ID: <CAFEAcA_hgd7P5fjgqpc00_PzoAdMzBuABombyAnk4ej6a2itoA@mail.gmail.com> (raw)
In-Reply-To: <20180507121126.gjeufzppsc7qspgm@sirius.home.kraxel.org>
On 7 May 2018 at 13:11, Gerd Hoffmann <kraxel@redhat.com> wrote:
>> This seems like a bit of an irritating reason to refuse to
>> allow multiple VGA devices though, since we could make
>> them work by having the vmstate be not-global.
>
> Multiple vga devices will also try to use the same isa vga
> ports. Seems that doesn't make qemu abort any more, which
> used to happen in older versions.
Oh, good point. Shouldn't we be checking for that on
some other thing than whether global_vmstate is set here,
though? Otherwise it won't work consistently for the
vga devices which pass 'false'.
thanks
-- PMM
next prev parent reply other threads:[~2018-05-07 13:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-07 10:10 [Qemu-devel] [PATCH] vga: print friendly error message in case multiple vga devices are added Gerd Hoffmann
2018-05-07 10:17 ` Peter Maydell
2018-05-07 12:11 ` Gerd Hoffmann
2018-05-07 13:36 ` Peter Maydell [this message]
2018-05-07 14:30 ` Gerd Hoffmann
2018-05-07 17:00 ` Peter Maydell
2018-05-08 7:14 ` Gerd Hoffmann
2018-05-07 18:10 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_hgd7P5fjgqpc00_PzoAdMzBuABombyAnk4ej6a2itoA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).