From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57671)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Z5Xjx-0005Bi-FL
	for qemu-devel@nongnu.org; Thu, 18 Jun 2015 07:12:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Z5Xjs-0004xr-GH
	for qemu-devel@nongnu.org; Thu, 18 Jun 2015 07:12:13 -0400
Received: from mail-yh0-f51.google.com ([209.85.213.51]:35954)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Z5Xjs-0004xe-CD
	for qemu-devel@nongnu.org; Thu, 18 Jun 2015 07:12:08 -0400
Received: by yhan67 with SMTP id n67so53596877yha.3
	for <qemu-devel@nongnu.org>; Thu, 18 Jun 2015 04:12:08 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20150618113745-mutt-send-email-mst@redhat.com>
References: <1434620035-10808-1-git-send-email-kraxel@redhat.com>
	<1434620035-10808-2-git-send-email-kraxel@redhat.com>
	<20150618113745-mutt-send-email-mst@redhat.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Thu, 18 Jun 2015 12:11:47 +0100
Message-ID: <CAFEAcA_iOJocVFAtnN5vaxTf6Bf-dM=Qxb5R61pZoWun-h=+aQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PULL 1/1] virtio-input: evdev passthrough
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>

On 18 June 2015 at 10:39, Michael S. Tsirkin <mst@redhat.com> wrote:
> On Thu, Jun 18, 2015 at 11:33:55AM +0200, Gerd Hoffmann wrote:
>> +static Property virtio_input_host_pci_properties[] = {
>> +    DEFINE_VIRTIO_INPUT_PROPERTIES(VirtIOInputPCI, vdev.input),
>> +    DEFINE_PROP_STRING("evdev", VirtIOInputHostPCI, vdev.evdev),
>> +    DEFINE_PROP_UINT32("vectors", VirtIOPCIProxy, nvectors, 2),
>> +    DEFINE_PROP_END_OF_LIST(),
>> +};
>> +
>
> Hmm I only noticed this now: I think properties
> should all move into virtio input, there is
> no reason to make them pci specific.

'vectors' is probably pci specific, but evdev isn't.

> Since you already added some properties, it's ok
> to apply this but please fix this with a patch on top.

Shuffling properties around later while trying to maintain
backcompat is painful, so I think we're better off just
making sure we have them in the right places to start with.

I'm dropping this pullreq from my queue.

thanks
-- PMM