* [PATCH] tests/qtest: Reduce npcm7xx_sdhci test image size
@ 2022-06-09 21:41 Hao Wu
2022-06-10 12:53 ` Peter Maydell
2022-06-10 13:10 ` Philippe Mathieu-Daudé via
0 siblings, 2 replies; 3+ messages in thread
From: Hao Wu @ 2022-06-09 21:41 UTC (permalink / raw)
To: peter.maydell
Cc: qemu-arm, qemu-devel, wuhaotsh, venture, Avi.Fishman, kfting,
hskinnemoen, f4bug, bin.meng, qemu-block, stmao,
richard.henderson, jsnow, lvivier, pbonzini, thuth
Creating 1GB image for a simple qtest is unnecessary
and could lead to failures. We reduce the image size
to 1MB to reduce the test overhead.
Signed-off-by: Hao Wu <wuhaotsh@google.com>
---
tests/qtest/npcm7xx_sdhci-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/npcm7xx_sdhci-test.c b/tests/qtest/npcm7xx_sdhci-test.c
index aa35a77e8d..5d68540e52 100644
--- a/tests/qtest/npcm7xx_sdhci-test.c
+++ b/tests/qtest/npcm7xx_sdhci-test.c
@@ -24,7 +24,7 @@
#define NPCM7XX_REG_SIZE 0x100
#define NPCM7XX_MMC_BA 0xF0842000
#define NPCM7XX_BLK_SIZE 512
-#define NPCM7XX_TEST_IMAGE_SIZE (1 << 30)
+#define NPCM7XX_TEST_IMAGE_SIZE (1 << 20)
char *sd_path;
--
2.36.1.476.g0c4daa206d-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tests/qtest: Reduce npcm7xx_sdhci test image size
2022-06-09 21:41 [PATCH] tests/qtest: Reduce npcm7xx_sdhci test image size Hao Wu
@ 2022-06-10 12:53 ` Peter Maydell
2022-06-10 13:10 ` Philippe Mathieu-Daudé via
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2022-06-10 12:53 UTC (permalink / raw)
To: Hao Wu
Cc: qemu-arm, qemu-devel, venture, Avi.Fishman, kfting, hskinnemoen,
f4bug, bin.meng, qemu-block, stmao, richard.henderson, jsnow,
lvivier, pbonzini, thuth
On Thu, 9 Jun 2022 at 22:41, Hao Wu <wuhaotsh@google.com> wrote:
>
> Creating 1GB image for a simple qtest is unnecessary
> and could lead to failures. We reduce the image size
> to 1MB to reduce the test overhead.
>
> Signed-off-by: Hao Wu <wuhaotsh@google.com>
> ---
> tests/qtest/npcm7xx_sdhci-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tests/qtest: Reduce npcm7xx_sdhci test image size
2022-06-09 21:41 [PATCH] tests/qtest: Reduce npcm7xx_sdhci test image size Hao Wu
2022-06-10 12:53 ` Peter Maydell
@ 2022-06-10 13:10 ` Philippe Mathieu-Daudé via
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé via @ 2022-06-10 13:10 UTC (permalink / raw)
To: Hao Wu, peter.maydell
Cc: qemu-arm, qemu-devel, venture, Avi.Fishman, kfting, hskinnemoen,
bin.meng, qemu-block, stmao, richard.henderson, jsnow, lvivier,
pbonzini, thuth
On 9/6/22 23:41, Hao Wu wrote:
> Creating 1GB image for a simple qtest is unnecessary
> and could lead to failures. We reduce the image size
> to 1MB to reduce the test overhead.
>
> Signed-off-by: Hao Wu <wuhaotsh@google.com>
> ---
> tests/qtest/npcm7xx_sdhci-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-10 13:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-09 21:41 [PATCH] tests/qtest: Reduce npcm7xx_sdhci test image size Hao Wu
2022-06-10 12:53 ` Peter Maydell
2022-06-10 13:10 ` Philippe Mathieu-Daudé via
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).