From: Peter Maydell <peter.maydell@linaro.org>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
QEMU Trivial <qemu-trivial@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH trivial for-2.12] Makefile: install gtk message catalogs if CONFIG_GTK=y too, not only =m
Date: Mon, 16 Apr 2018 10:26:59 +0100 [thread overview]
Message-ID: <CAFEAcA_isnmigyPV=bZtyJ3r++8pc__7b9z12FEtd6SHJum9mg@mail.gmail.com> (raw)
In-Reply-To: <20180414142739.23375-1-mjt@msgid.tls.msk.ru>
On 14 April 2018 at 15:27, Michael Tokarev <mjt@tls.msk.ru> wrote:
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 727ef118f3..8644c2e918 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -856,7 +856,7 @@ ifneq ($(BLOBS),)
> $(INSTALL_DATA) $(SRC_PATH)/pc-bios/$$x "$(DESTDIR)$(qemu_datadir)"; \
> done
> endif
> -ifeq ($(CONFIG_GTK),m)
> +ifneq ($(filter $(CONFIG_GTK),y m),)
> $(MAKE) -C po $@
> endif
> $(INSTALL_DIR) "$(DESTDIR)$(qemu_datadir)/keymaps"
> --
> 2.11.0
"trivial" and "for 2.12" don't make much sense together at this point in
the release cycle. Is this important enough to go into rc4, or not?
thanks
-- PMM
next prev parent reply other threads:[~2018-04-16 9:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-14 14:27 [Qemu-devel] [PATCH trivial for-2.12] Makefile: install gtk message catalogs if CONFIG_GTK=y too, not only =m Michael Tokarev
2018-04-16 2:50 ` [Qemu-devel] [Qemu-trivial] " Philippe Mathieu-Daudé
2018-04-16 9:26 ` Peter Maydell [this message]
2018-04-16 9:37 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA_isnmigyPV=bZtyJ3r++8pc__7b9z12FEtd6SHJum9mg@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).