From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55842)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1XRNqw-0004QE-So
	for qemu-devel@nongnu.org; Tue, 09 Sep 2014 12:01:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1XRNqp-0005Tu-8N
	for qemu-devel@nongnu.org; Tue, 09 Sep 2014 12:01:10 -0400
Received: from mail-la0-f46.google.com ([209.85.215.46]:48805)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1XRNqp-0005Tj-2d
	for qemu-devel@nongnu.org; Tue, 09 Sep 2014 12:01:03 -0400
Received: by mail-la0-f46.google.com with SMTP id pv20so19939087lab.33
	for <qemu-devel@nongnu.org>; Tue, 09 Sep 2014 09:01:01 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <540F2325.3070009@linaro.org>
References: <1410249273-6063-1-git-send-email-eric.auger@linaro.org>
	<1410249273-6063-3-git-send-email-eric.auger@linaro.org>
	<540EDECB.1000801@redhat.com> <540F2325.3070009@linaro.org>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Tue, 9 Sep 2014 17:00:41 +0100
Message-ID: <CAFEAcA_jDaCy7WrbTA0grDskodg2R=G5OSvDaxngb+ees1JszA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v3 2/6] hw/arm/dyn_sysbus_devtree: helpers
 for sysbus device dynamic dt node generation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Auger <eric.auger@linaro.org>
Cc: Joel Schopp <joel.schopp@amd.com>, Alex Williamson <alex.williamson@redhat.com>, Kim Phillips <kim.phillips@freescale.com>, eric.auger@st.com, Patch Tracking <patches@linaro.org>, Marc Zyngier <marc.zyngier@arm.com>, manish.jaggi@caviumnetworks.com, Will Deacon <will.deacon@arm.com>, QEMU Developers <qemu-devel@nongnu.org>, Alvise Rigo <a.rigo@virtualopensystems.com>, Bharat Bhushan <Bharat.Bhushan@freescale.com>, Alexander Graf <agraf@suse.de>, "kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>, Antonios Motakis <a.motakis@virtualopensystems.com>, Stuart Yoder <stuart.yoder@freescale.com>, Paolo Bonzini <pbonzini@redhat.com>, =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>, Christoffer Dall <christoffer.dall@linaro.org>

On 9 September 2014 16:56, Eric Auger <eric.auger@linaro.org> wrote:
> irq_start: needed because when the "interrupts" property is set for the
> leaf component the irq number is irq_start +
> object_property_get_int(obj, "irq[i]", NULL)
> irq[i] being in [0, params->platform_bus_num_irqs]
>
> intc: this was in case the leaf component would use "interrupt-parent"
> prop. I miss experience on device trees and I don't know if it make
> sense the leaf component uses a different interrupt controller than the
> parent platform bus or if such property is mandatory in some cases.
> Maybe not needed indeed.

Somewhat tangential, but for passthrough devices how
do we decide whether the device tree node needs to
mark the interrupt as edge or level triggered?
Presumably this is going to be a "depends on what
the passed through hardware is" thing...

-- PMM