From: Peter Maydell <peter.maydell@linaro.org>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Alex Williamson <alex.williamson@redhat.com>,
Xen Devel <xen-devel@lists.xensource.com>,
QEMU-devel <qemu-devel@nongnu.org>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [Qemu-devel] [PATCH V2 01/10] configure: Introduce --enable-xen-pci-passthrough.
Date: Wed, 19 Oct 2011 15:48:55 +0100 [thread overview]
Message-ID: <CAFEAcA_jX8t_8UtKOodXAOD-Arz2WPX71vWrLBZwT_4ODG_d0g@mail.gmail.com> (raw)
In-Reply-To: <1319032613-10560-2-git-send-email-anthony.perard@citrix.com>
On 19 October 2011 14:56, Anthony PERARD <anthony.perard@citrix.com> wrote:
> +if test "$xen_pci_passthrough" != "no"; then
> + if test "$xen" = "yes" -a "$linux" = "yes"; then
> + xen_pci_passthrough=yes
> + else
> + if test "$xen_pci_passthrough" = "yes"; then
> + feature_not_found "Xen PCI Passthrough without Xen or not on linux"
> + fi
> + xen_pci_passthrough=no
> + fi
> +fi
The -a flag to test is obsolete -- don't use it in new code.
This is a bit of a misuse of the feature_not_found function IMHO.
(Also, Linux needs a capital letter.)
-- PMM
next prev parent reply other threads:[~2011-10-19 14:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-19 13:56 [Qemu-devel] [PATCH V2 00/10] Xen PCI Passthrough Anthony PERARD
2011-10-19 13:56 ` [Qemu-devel] [PATCH V2 01/10] configure: Introduce --enable-xen-pci-passthrough Anthony PERARD
2011-10-19 14:48 ` Peter Maydell [this message]
2011-10-19 15:01 ` Anthony PERARD
2011-10-20 10:57 ` Stefano Stabellini
2011-10-24 14:02 ` Anthony PERARD
2011-10-19 13:56 ` [Qemu-devel] [PATCH V2 02/10] Introduce HostPCIDevice to access a pci device on the host Anthony PERARD
2011-10-20 10:57 ` Stefano Stabellini
2011-10-24 14:25 ` Anthony PERARD
2011-10-19 13:56 ` [Qemu-devel] [PATCH V2 03/10] pci.c: Add pci_check_bar_overlap Anthony PERARD
2011-10-19 13:56 ` [Qemu-devel] [PATCH V2 04/10] pci_ids: Add INTEL_82599_VF id Anthony PERARD
2011-10-19 13:56 ` [Qemu-devel] [PATCH V2 05/10] pci_regs: Fix value of PCI_EXP_TYPE_RC_EC Anthony PERARD
2011-10-19 13:56 ` [Qemu-devel] [PATCH V2 06/10] pci_regs: Add PCI_EXP_TYPE_PCIE_BRIDGE Anthony PERARD
2011-10-19 13:56 ` [Qemu-devel] [PATCH V2 07/10] Introduce apic-msidef.h Anthony PERARD
2011-10-19 13:56 ` [Qemu-devel] [PATCH V2 08/10] Introduce Xen PCI Passthrough, qdevice (1/3) Anthony PERARD
2011-10-20 10:59 ` Stefano Stabellini
2011-10-24 14:29 ` Anthony PERARD
2011-10-19 13:56 ` [Qemu-devel] [PATCH V2 09/10] Introduce Xen PCI Passthrough, PCI config space helpers (2/3) Anthony PERARD
2011-10-20 11:01 ` Stefano Stabellini
2011-10-24 14:33 ` Anthony PERARD
2011-10-19 13:56 ` [Qemu-devel] [PATCH V2 10/10] Introduce Xen PCI Passthrough, MSI (3/3) Anthony PERARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_jX8t_8UtKOodXAOD-Arz2WPX71vWrLBZwT_4ODG_d0g@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=alex.williamson@redhat.com \
--cc=anthony.perard@citrix.com \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).