qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 2/4] .travis.yml: reduce target list on core configure tweaks
Date: Fri, 15 Apr 2016 17:07:50 +0100	[thread overview]
Message-ID: <CAFEAcA_ncTa_rORwCu396Dti169wzKHuGtJNNpvdTjU-Xrg++w@mail.gmail.com> (raw)
In-Reply-To: <1460735821-12775-3-git-send-email-alex.bennee@linaro.org>

On 15 April 2016 at 16:56, Alex Bennée <alex.bennee@linaro.org> wrote:
> A number of configure options only really affect the core code and any
> arch specific stuff should be flushed out by other builds:
>
>   - trace-backends, log build is all targets, others can be less
>   - --disable-build, ensuring disabling stuff doesn't break host
>   - co-routine, default already built with all, common API
>   - tcg interpreter is front end agnostic
>
> I've used the ./configure --target-list stem support to do all of one
> arch type in each reduced build.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  .travis.yml | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index 50ac17f..d13bffc 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -45,10 +45,10 @@ env:
>    matrix:
>      - CONFIG=""
>      - CONFIG="--enable-debug --enable-debug-tcg --enable-trace-backends=log"
> -    - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-uuid --disable-libusb"
> -    - CONFIG="--enable-modules"
> -    - CONFIG="--with-coroutine=ucontext"
> -    - CONFIG="--with-coroutine=sigaltstack"
> +    - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-uuid --disable-libusb --target-list=86"
> +    - CONFIG="--enable-modules --target-list=86"

I'm not really convinced by the wildcarding, and this seems like
a good demonstration of why it's overbroad. "86" ??

The wildcarding gives you a configure command that will
potentially change behaviour as we introduce new targets,
too; that makes me a bit nervous.

thanks
-- PMM

  reply	other threads:[~2016-04-15 16:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-15 15:56 [Qemu-devel] [PATCH 0/4] Current Travis queue Alex Bennée
2016-04-15 15:56 ` [Qemu-devel] [PATCH 1/4] ./configure: accept stems to match a range of targets Alex Bennée
2016-04-15 15:56 ` [Qemu-devel] [PATCH 2/4] .travis.yml: reduce target list on core configure tweaks Alex Bennée
2016-04-15 16:07   ` Peter Maydell [this message]
2016-04-18  9:15     ` Alex Bennée
2016-04-18  9:17       ` Peter Maydell
2016-04-18  9:50         ` Alex Bennée
2016-04-15 15:57 ` [Qemu-devel] [PATCH 3/4] .travis.yml: add libnfs-dev for NFS block driver Alex Bennée
2016-04-15 15:57 ` [Qemu-devel] [PATCH 4/4] .travis.yml: add trusty GCE target Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA_ncTa_rORwCu396Dti169wzKHuGtJNNpvdTjU-Xrg++w@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).