From: Peter Maydell <peter.maydell@linaro.org>
To: Leon Alrae <leon.alrae@imgtec.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
qemu-stable <qemu-stable@nongnu.org>
Subject: Re: [Qemu-devel] [PULL 1/1] mips: fix broken fulong2e machine
Date: Fri, 17 Apr 2015 11:58:13 +0100 [thread overview]
Message-ID: <CAFEAcA_o6sQ5HTfD4rUx6tAONbGTnoHP3Qd+q++fHMvLd136bg@mail.gmail.com> (raw)
In-Reply-To: <5530E540.2060007@imgtec.com>
On 17 April 2015 at 11:49, Leon Alrae <leon.alrae@imgtec.com> wrote:
> On 17/04/2015 11:42, Peter Maydell wrote:
>> On 17 April 2015 at 10:46, Leon Alrae <leon.alrae@imgtec.com> wrote:
>>> After commit 5312bd8 the bonito_readl() and bonito_writel() have been
>>> accessing incorrect addresses. Consequently QEMU is crashing when trying
>>> to boot Linux kernel on fulong2e machine.
>>>
>>> Cc: qemu-stable@nongnu.org
>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>> Signed-off-by: Leon Alrae <leon.alrae@imgtec.com>
>>
>> This is Paolo's patch, right? (it has his signoff). It
>> should have him as the author as well, but you seem to have
>> lost that...
>
> Well, I asked Paolo if he wanted to send the patch, but he suggested to
> send the pull request by myself and just put his Signed-off-by line.
It's fine for you to send the patch, but you need to send it with
a From line in the commit message from him, not you.
-- PMM
next prev parent reply other threads:[~2015-04-17 10:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-17 9:46 [Qemu-devel] [PULL 0/1 for-2.3] fulong2e bugfix Leon Alrae
2015-04-17 9:46 ` [Qemu-devel] [PULL 1/1] mips: fix broken fulong2e machine Leon Alrae
2015-04-17 10:42 ` Peter Maydell
2015-04-17 10:49 ` Leon Alrae
2015-04-17 10:58 ` Peter Maydell [this message]
2015-04-17 11:07 ` Leon Alrae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_o6sQ5HTfD4rUx6tAONbGTnoHP3Qd+q++fHMvLd136bg@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=leon.alrae@imgtec.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).