From: Peter Maydell <peter.maydell@linaro.org>
To: Fabien Chouteau <chouteau@adacore.com>
Cc: qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] PPC/GDB: handle read and write of fpscr
Date: Tue, 19 Mar 2013 17:21:57 +0000 [thread overview]
Message-ID: <CAFEAcA_oKdZVYJDZ+ZrRYYkvcWOPhqK6CTscqSWzKPSDYD2T=g@mail.gmail.com> (raw)
In-Reply-To: <51489E47.5040204@adacore.com>
On 19 March 2013 17:20, Fabien Chouteau <chouteau@adacore.com> wrote:
> On 03/19/2013 04:23 PM, Peter Maydell wrote:
>> The way we do this on ARM for cpsr_read is:
>> * cpsr_read() is defined in target-arm/cpu.h
>> * gdbstub.c calls cpsr_read()
>> * HELPER(cpsr_read) is mostly a wrapper calling cpsr_read()
>> * helper.h declares HELPER(cpsr_read) as usual
>>
>> I'm not sure you want to include helper.h.
>>
>
> Cleaner solution indeed. I'll do the opposite, store_fpscr
> calls helper_store_fpscr.
I think that way round is kind of backwards personally (HELPER
functions are for TCG generated code to call) but it doesn't
make much difference really.
-- PMM
next prev parent reply other threads:[~2013-03-19 17:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 12:03 [Qemu-devel] [PATCH] PPC/GDB: handle read and write of fpscr Fabien Chouteau
2013-03-19 12:10 ` Alexander Graf
2013-03-19 12:13 ` Peter Maydell
2013-03-19 12:16 ` Alexander Graf
2013-03-19 15:14 ` Fabien Chouteau
2013-03-19 15:23 ` Peter Maydell
2013-03-19 17:20 ` Fabien Chouteau
2013-03-19 17:21 ` Peter Maydell [this message]
2013-03-19 18:32 ` Richard Henderson
2013-03-19 19:48 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA_oKdZVYJDZ+ZrRYYkvcWOPhqK6CTscqSWzKPSDYD2T=g@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=agraf@suse.de \
--cc=chouteau@adacore.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).