qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
	Kevin Wolf <kwolf@redhat.com>,
	Ishani Chugh <chugh.ishani@research.iiit.ac.in>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Qemu-block <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-iotests: add a "how to" to ./README
Date: Wed, 26 Jul 2017 12:50:37 +0100	[thread overview]
Message-ID: <CAFEAcA_oapBTwRqHH0Rn8gJ6FnRLs2isejYMzr9aXLLwS5Tx+w@mail.gmail.com> (raw)
In-Reply-To: <20170726113308.GG18489@stefanha-x1.localdomain>

On 26 July 2017 at 12:33, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> On Tue, Jul 25, 2017 at 04:34:19PM +0100, Peter Maydell wrote:
>> On 25 July 2017 at 16:20, Stefan Hajnoczi <stefanha@gmail.com> wrote:
>> > On Mon, Jul 24, 2017 at 11:20:44AM +0100, Peter Maydell wrote:
>> >> Should ./check be run from the source tree, or the build tree? The
>> >> existing README text doesn't say and I don't think your additions
>> >> do either.
>> >
>> > It doesn't matter, both should work.  The script detects both
>> > possibilities and rejigs itself to compensate.
>>
>> Does that mean
>>  if you run it from the source tree in a tree configured
>>  for out of tree build it will:
>>  (a) pollute your source tree with test output and binaries
>>  (b) give you a helpful message about what to do
>>  (c) magically find the build tree somehow
>>  (d) not need to write any binaries/test output/temp files at all
>>
>> ?
>
> I think it would fail since the binaries would be missing in the source
> tree.

That sounds like "the README should say you need to run it
from the build tree", then ?

thanks
-- PMM

  reply	other threads:[~2017-07-26 11:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-21  9:34 [Qemu-devel] [PATCH] qemu-iotests: add a "how to" to ./README Stefan Hajnoczi
2017-07-21 12:16 ` Eric Blake
2017-07-21 15:51   ` Stefan Hajnoczi
2017-07-23 14:18     ` Philippe Mathieu-Daudé
2017-07-24 10:06       ` Stefan Hajnoczi
2017-07-24 21:50     ` [Qemu-devel] [Qemu-block] " John Snow
2017-07-22  9:03 ` Manos Pitsidianakis
2017-07-24  9:11 ` [Qemu-devel] " Kevin Wolf
2017-07-25 15:22   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-07-24 10:20 ` [Qemu-devel] " Peter Maydell
2017-07-25 15:20   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-07-25 15:34     ` Peter Maydell
2017-07-26 11:33       ` Stefan Hajnoczi
2017-07-26 11:50         ` Peter Maydell [this message]
2017-07-24 14:28 ` [Qemu-devel] " Eric Blake
2017-07-24 14:33   ` Kevin Wolf
2017-07-24 14:34   ` Peter Maydell
2017-07-24 14:41     ` Eric Blake
2017-07-26 18:42 ` [Qemu-devel] [Qemu-block] " Jeff Cody

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA_oapBTwRqHH0Rn8gJ6FnRLs2isejYMzr9aXLLwS5Tx+w@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=chugh.ishani@research.iiit.ac.in \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).