From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47621) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ay0BT-0007i9-FB for qemu-devel@nongnu.org; Wed, 04 May 2016 13:02:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ay0BH-0004TC-Bl for qemu-devel@nongnu.org; Wed, 04 May 2016 13:01:54 -0400 Received: from mail-yw0-x233.google.com ([2607:f8b0:4002:c05::233]:32976) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ay0BG-0004HF-5Q for qemu-devel@nongnu.org; Wed, 04 May 2016 13:01:47 -0400 Received: by mail-yw0-x233.google.com with SMTP id t10so105700614ywa.0 for ; Wed, 04 May 2016 10:01:27 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1459332567-13629-1-git-send-email-zxq_yx_007@163.com> From: Peter Maydell Date: Wed, 4 May 2016 18:01:04 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 0/9] QOM'ify hw/intc files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: xiaoqiang zhao Cc: QEMU Developers , "Edgar E. Iglesias" , Igor Mitsyanko , Fabien Chouteau , Peter Chubb , Michael Walle , Blue Swirl , Mark Cave-Ayland Oops, just noticed the SPARC maintainers weren't cc'd on this. -- PMM On 4 May 2016 at 15:56, Peter Maydell wrote: > On 30 March 2016 at 11:09, xiaoqiang zhao wrote: >> This patch set QOM'ify files under hw/intc directory. See each commit >> message for details. >> >> xiaoqiang zhao (9): >> hw/intc: QOM'ify etraxfs_pic.c >> hw/intc: QOM'ify exynos4210_combiner.c >> hw/intc: QOM'ify exynos4210_gic.c >> hw/intc: QOM'ify imx_avic.c >> hw/intc: QOM'ify lm32_pic.c >> hw/intc: QOM'ify pl190.c >> hw/intc: QOM'ify slavio_intctl.c >> hw/intc: QOM'ify grlib_irqmp.c >> hw/intc: QOM'ify omap_intc.c >> >> hw/intc/etraxfs_pic.c | 13 +++++---- >> hw/intc/exynos4210_combiner.c | 14 +++++----- >> hw/intc/exynos4210_gic.c | 39 ++++++++++++++------------- >> hw/intc/grlib_irqmp.c | 27 +++++++++++-------- >> hw/intc/imx_avic.c | 15 +++++------ >> hw/intc/lm32_pic.c | 12 ++++----- >> hw/intc/omap_intc.c | 63 +++++++++++++++++++++++++------------------ >> hw/intc/pl190.c | 13 +++++---- >> hw/intc/slavio_intctl.c | 14 +++++----- >> 9 files changed, 109 insertions(+), 101 deletions(-) > > Hi. I had a comment on patch 9 (omap_intc), but 1-8 look good. > Only patches 2, 3, 4 and 6 are ARM-related. > > SPARC, lm32, CRIS maintainers: do you want to take your patches > or shall I just take 1-8 through the target-arm.next tree? > > Xaioqiang: if you're planning to do more of these QOMify > series in future it might be easier on maintainers if you > split them up by target architecture rather than by > type-of-device. Otherwise we have lots of these series which > touch devices for four different architectures and should > really go through four different maintainers. > > I forget if I've said this before, but I do really appreciate > these patches -- cleanup of older devices to bring them up > to modern QEMU standards is a thankless task but it's an > important one. > > thanks > -- PMM