From: Peter Maydell <peter.maydell@linaro.org>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Blue Swirl <blauwirbel@gmail.com>, qemu-arm <qemu-arm@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 09/10] arm: virt: parse cpu_model only once
Date: Wed, 8 Jun 2016 18:25:36 +0100 [thread overview]
Message-ID: <CAFEAcA_p_1wfG18U-zttQG4fXXJy6nbFcUL0s6piyLtwn1MB-g@mail.gmail.com> (raw)
In-Reply-To: <20160608165500.GN18662@thinpad.lan.raisama.net>
On 8 June 2016 at 17:55, Eduardo Habkost <ehabkost@redhat.com> wrote:
> On Mon, Jun 06, 2016 at 05:16:51PM +0200, Igor Mammedov wrote:
>> considering that features are converted to
>> global properties and global properties are
>> automatically applied to every new instance
>> of created CPU (at object_new() time), there
>> is no point in parsing cpu_model string every
>> time a CPU created.
>> So move parsing outside CPU creation loop and
>> do it only once.
>> Parsing also should be done before any CPU is
>> created so that features would affect the first
>> CPU a well.
>>
>> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
>
> Peter, do you prefer to get this included through my tree with
> the rest of the series, or wait to included it in your tree after
> the other patches get merged to master?
Seems easiest for you to take it.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
next prev parent reply other threads:[~2016-06-08 17:25 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 15:16 [Qemu-devel] [PATCH 00/10] cpus: make "-cpu cpux, features" global properties Igor Mammedov
2016-06-06 15:16 ` [Qemu-devel] [PATCH 01/10] target-i386: Remove xlevel & hv-spinlocks option fixups Igor Mammedov
2016-06-06 15:16 ` [Qemu-devel] [PATCH 02/10] target-i386: cpu: move features logic that requires CPUState to realize time Igor Mammedov
2016-06-07 20:25 ` Eduardo Habkost
2016-06-07 21:07 ` Eric Blake
2016-06-07 22:29 ` Eduardo Habkost
2016-06-06 15:16 ` [Qemu-devel] [PATCH 03/10] target-i386: cpu: move xcc->kvm_required check " Igor Mammedov
2016-06-07 20:23 ` Eduardo Habkost
2016-06-07 20:28 ` Eduardo Habkost
2016-06-09 18:34 ` Eduardo Habkost
2016-06-10 7:15 ` Igor Mammedov
2016-06-10 11:39 ` Eduardo Habkost
2016-06-10 11:48 ` [Qemu-devel] [PATCH] target-i386: Remove assert(kvm_enabled()) from host_x86_cpu_initfn() Eduardo Habkost
2016-06-10 12:40 ` Igor Mammedov
2016-06-06 15:16 ` [Qemu-devel] [PATCH 04/10] target-i386: cpu: use cpu_generic_init() in cpu_x86_init() Igor Mammedov
2016-06-07 20:29 ` Eduardo Habkost
2016-06-06 15:16 ` [Qemu-devel] [PATCH 05/10] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr Igor Mammedov
2016-06-07 20:37 ` Eduardo Habkost
2016-06-06 15:16 ` [Qemu-devel] [PATCH 06/10] target-i386: print obsolete warnings if +-features are used Igor Mammedov
2016-06-07 11:44 ` Paolo Bonzini
2016-06-07 12:32 ` Igor Mammedov
2016-06-07 12:36 ` Paolo Bonzini
2016-06-07 12:54 ` Igor Mammedov
2016-06-07 13:00 ` Paolo Bonzini
2016-06-07 13:26 ` Igor Mammedov
2016-06-07 15:17 ` Eduardo Habkost
2016-06-06 15:16 ` [Qemu-devel] [PATCH 07/10] target-sparc: cpu: use sparc_cpu_parse_features() directly Igor Mammedov
2016-06-08 16:30 ` Eduardo Habkost
2016-06-10 11:51 ` Eduardo Habkost
2016-06-10 18:32 ` Mark Cave-Ayland
2016-06-06 15:16 ` [Qemu-devel] [PATCH 08/10] cpu: use CPUClass->parse_features() as convertor to global properties Igor Mammedov
2016-06-08 16:47 ` Eduardo Habkost
2016-06-09 12:38 ` Igor Mammedov
2016-06-09 13:23 ` Eduardo Habkost
2016-06-09 13:40 ` Igor Mammedov
2016-06-06 15:16 ` [Qemu-devel] [PATCH 09/10] arm: virt: parse cpu_model only once Igor Mammedov
2016-06-08 16:55 ` Eduardo Habkost
2016-06-08 17:25 ` Peter Maydell [this message]
2016-06-06 15:16 ` [Qemu-devel] [PATCH 10/10] pc: parse cpu features " Igor Mammedov
2016-06-08 17:03 ` Eduardo Habkost
2016-06-09 12:07 ` Igor Mammedov
2016-06-09 13:25 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_p_1wfG18U-zttQG4fXXJy6nbFcUL0s6piyLtwn1MB-g@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=blauwirbel@gmail.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).